THRIFT-5725: Fix the comparison check for bio_get_fd

psarkar-datos · Jens-G · commit bccca9301ded · 2023-07-08T10:18:33.000+02:00
Client: cpp Patch: Prasenjit Sarkar This closes #2831
diff --git a/lib/cpp/src/thrift/transport/TSSLSocket.cpp b/lib/cpp/src/thrift/transport/TSSLSocket.cpp
@@ -825,7 +825,7 @@ unsigned int TSSLSocket::waitForEvent(bool wantRead) {
     throw TSSLException("SSL_get_?bio returned nullptr");
   }
 
-  if (BIO_get_fd(bio, &fdSocket) <= 0) {
+  if (BIO_get_fd(bio, &fdSocket) < 0) {
     throw TSSLException("BIO_get_fd failed");
   }
 

Original file line number	Diff line number	Diff line change
`@@ -825,7 +825,7 @@ unsigned int TSSLSocket::waitForEvent(bool wantRead) {`
`825`	`825`	`throw TSSLException("SSL_get_?bio returned nullptr");`
`826`	`826`	`}`
`827`	`827`
`828`		`- if (BIO_get_fd(bio, &fdSocket) <= 0) {`
	`828`	`+ if (BIO_get_fd(bio, &fdSocket) < 0) {`
`829`	`829`	`throw TSSLException("BIO_get_fd failed");`
`830`	`830`	`}`
`831`	`831`