From b278c38a5260d310ff49b97519e8d855aaee058d Mon Sep 17 00:00:00 2001 From: Craig Date: Tue, 14 Apr 2020 14:08:12 -0700 Subject: [PATCH 1/2] Disabling recording in Cypress tests --- .github/workflows/superset-e2e.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/superset-e2e.yml b/.github/workflows/superset-e2e.yml index 0e1ecfa46aed4..2c3bca0574f41 100644 --- a/.github/workflows/superset-e2e.yml +++ b/.github/workflows/superset-e2e.yml @@ -22,7 +22,6 @@ jobs: REDIS_PORT: 16379 CI: github-actions GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} services: postgres: image: postgres:10-alpine @@ -69,7 +68,7 @@ jobs: cd ${{ github.workspace }}/superset-frontend/cypress-base/ npm run cypress -- run \ --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \ - --record --group "${{ env.CYPRESS_GROUP }}" \ + --record false --group "${{ env.CYPRESS_GROUP }}" \ --ci-build-id ${{ github.event_name }}-${{ github.run_id }} - name: Cypress run SQL Lab (with backend persist) @@ -87,5 +86,5 @@ jobs: cd ${{ github.workspace }}/superset-frontend/cypress-base/ npm run cypress -- run \ --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \ - --record --group "${{ env.CYPRESS_GROUP }}" \ + --record false --group "${{ env.CYPRESS_GROUP }}" \ --ci-build-id ${{ github.event_name }}-${{ github.run_id }} From 2909c82ca9fc034d879f587e2da421caa8c53e17 Mon Sep 17 00:00:00 2001 From: Craig Date: Tue, 14 Apr 2020 14:22:18 -0700 Subject: [PATCH 2/2] Removing --group --ci-build-id --- .github/workflows/superset-e2e.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/superset-e2e.yml b/.github/workflows/superset-e2e.yml index 2c3bca0574f41..a093f828016a8 100644 --- a/.github/workflows/superset-e2e.yml +++ b/.github/workflows/superset-e2e.yml @@ -66,10 +66,7 @@ jobs: sleep 3 # wait for the Flask app to start cd ${{ github.workspace }}/superset-frontend/cypress-base/ - npm run cypress -- run \ - --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \ - --record false --group "${{ env.CYPRESS_GROUP }}" \ - --ci-build-id ${{ github.event_name }}-${{ github.run_id }} + npm run cypress -- run --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" --record false - name: Cypress run SQL Lab (with backend persist) env: @@ -84,7 +81,4 @@ jobs: sleep 3 # wait for the Flask app to start cd ${{ github.workspace }}/superset-frontend/cypress-base/ - npm run cypress -- run \ - --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \ - --record false --group "${{ env.CYPRESS_GROUP }}" \ - --ci-build-id ${{ github.event_name }}-${{ github.run_id }} + npm run cypress -- run --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" --record false