From 4a9e3ffa286c573e46d1f9211902803b917e1f82 Mon Sep 17 00:00:00 2001 From: Christine Chambers Date: Tue, 4 Sep 2018 15:21:43 -0700 Subject: [PATCH 1/2] bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. --- superset/assets/src/explore/controls.jsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx index cb46684eeeeaa..7d30b50543c33 100644 --- a/superset/assets/src/explore/controls.jsx +++ b/superset/assets/src/explore/controls.jsx @@ -1815,6 +1815,8 @@ export const controls = { isFloat: true, description: t('Latitude of default viewport'), places: 8, + // Viewport latitude changes shouldn't prompt user to re-run query + dontRefreshOnChange: true, }, viewport_longitude: { @@ -1824,6 +1826,8 @@ export const controls = { isFloat: true, description: t('Longitude of default viewport'), places: 8, + // Viewport longitude changes shouldn't prompt user to re-run query + dontRefreshOnChange: true, }, render_while_dragging: { From cc44ec543f3840c0572ad92b442ef96ed91ebb71 Mon Sep 17 00:00:00 2001 From: Christine Chambers Date: Tue, 4 Sep 2018 15:56:52 -0700 Subject: [PATCH 2/2] Prevent query overlay on viewport zoom also. --- superset/assets/src/explore/controls.jsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx index 7d30b50543c33..8c063a7fc70db 100644 --- a/superset/assets/src/explore/controls.jsx +++ b/superset/assets/src/explore/controls.jsx @@ -1806,6 +1806,8 @@ export const controls = { default: 11, description: t('Zoom level of the map'), places: 8, + // Viewport zoom shouldn't prompt user to re-run query + dontRefreshOnChange: true, }, viewport_latitude: {