From 7de57bfbb671dc99f1371c8dfdee64d8d55357b0 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Thu, 1 Feb 2024 18:10:50 -0800 Subject: [PATCH 1/3] fix(ci): typo in my bash script I couldn't fin a proper way to test the `workflow_dispatch` even, even from the gh CLI, so I had to test it using other events in my branch (on:pull_request), but never tested the inside of my `if` in bash. Anyhow, was flying blind, but I think this time it should work. --- .github/workflows/docker-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml index 0d0770db28d5f..b0f5321ccbe35 100644 --- a/.github/workflows/docker-release.yml +++ b/.github/workflows/docker-release.yml @@ -75,7 +75,7 @@ jobs: FORCE_LATEST="" if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then # in the case of a manually-triggered run, read release from input - RELEASE ="${{ github.event.inputs.release }}" + RELEASE="${{ github.event.inputs.release }}" if [ "${{ github.event.inputs.force-latest }}" = "true" ]; then FORCE_LATEST="--force-latest" fi From c264e535579ced98a2f3f6798d2c5c074d092e1c Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Thu, 1 Feb 2024 18:24:29 -0800 Subject: [PATCH 2/3] trying something to be able to git checkout during workflow execution --- .github/workflows/docker-release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml index b0f5321ccbe35..b5de513eaba46 100644 --- a/.github/workflows/docker-release.yml +++ b/.github/workflows/docker-release.yml @@ -59,6 +59,7 @@ jobs: persist-credentials: false submodules: recursive ref: ${{ github.ref }} + fetch-depth: 0 - name: Set up QEMU uses: docker/setup-qemu-action@v3 From 9a2938a3356871e12ce9257125d58a80ac1941f9 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Thu, 1 Feb 2024 18:27:12 -0800 Subject: [PATCH 3/3] set EVENT --- .github/workflows/docker-release.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml index b5de513eaba46..3ba7b6bf42fd0 100644 --- a/.github/workflows/docker-release.yml +++ b/.github/workflows/docker-release.yml @@ -74,6 +74,7 @@ jobs: run: | RELEASE="${{ github.event.release.tag_name }}" FORCE_LATEST="" + EVENT="${{github.event_name}}" if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then # in the case of a manually-triggered run, read release from input RELEASE="${{ github.event.inputs.release }}" @@ -84,10 +85,11 @@ jobs: cp ./scripts/build_docker.py /tmp git checkout "${{ github.event.inputs.git-ref }}" cp /tmp/build_docker.py scripts/ + EVENT="release" fi pip install click ./scripts/build_docker.py \ ${{ matrix.build_preset }} \ - "${{ github.event_name }}" \ + "$EVENT" \ --build_context_ref "$RELEASE" \ --platform ${{ matrix.platform }} $FORCE_LATEST