From ee21193937650528cebc50a796b072d8923cca3e Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Wed, 31 Mar 2021 20:56:49 -0700 Subject: [PATCH 1/2] update listview feature flag --- superset/config.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/superset/config.py b/superset/config.py index 0976e46c4efae..c0d5852e18605 100644 --- a/superset/config.py +++ b/superset/config.py @@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument # always be the table layout if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]: DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True +else: + DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False # This is merely a default. FEATURE_FLAGS: Dict[str, bool] = {} From 8e830f45ce81a0438b309d6f81ff60f0ec5471e6 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Thu, 8 Apr 2021 11:04:56 -0700 Subject: [PATCH 2/2] remove check --- superset/config.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/superset/config.py b/superset/config.py index c0d5852e18605..be2cd39075a8d 100644 --- a/superset/config.py +++ b/superset/config.py @@ -361,14 +361,6 @@ def _try_json_readsha( # pylint: disable=unused-argument "ENABLE_EXPLORE_DRAG_AND_DROP": False, } -# Set the default view to card/grid view if thumbnail support is enabled. -# Setting LISTVIEWS_DEFAULT_CARD_VIEW to False will force the default view to -# always be the table layout -if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]: - DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True -else: - DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False - # This is merely a default. FEATURE_FLAGS: Dict[str, bool] = {}