Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UK GeoJson not ISO 3166-2 Compliant #3863

Closed
alanmcruickshank opened this issue Nov 14, 2017 · 1 comment · Fixed by #3911
Closed

UK GeoJson not ISO 3166-2 Compliant #3863

alanmcruickshank opened this issue Nov 14, 2017 · 1 comment · Fixed by #3911

Comments

@alanmcruickshank
Copy link
Contributor

Superset version

0.20.5

Issue

In the currently packaged uk.geojson file not all ISO 3166-2 Regions are represented. Currently for the Metropolitan areas of the UK, the uk.geojson file included with superset includes the county codes (e.g. GB-WY, GB-TAW, etc...) which aren't part of ISO 3166-2, they should instead have the metropolitan area codes (e.g. GB-BRD, GB-LDS, GB-NET, etc...), which are the next level of subdivision to be compliant.

This means on correctly formatted data, you get a map with blank bits in the Country Map Viz.

The affected areas correspond exactly to this picture from wikipedia: https://upload.wikimedia.org/wikipedia/commons/9/92/English_metropolitan_boroughs_2009.svg

To fix this we would need to update the current geojson file to have the right entities in it. Any idea where the current ones came from? There's an up to date version of most of the dataset available from data.gov.uk here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants