Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label for first group by clause in time series - bar chart is always undefined #3590

Closed
3 tasks done
xrmx opened this issue Oct 4, 2017 · 4 comments · Fixed by #3594
Closed
3 tasks done

label for first group by clause in time series - bar chart is always undefined #3590

xrmx opened this issue Oct 4, 2017 · 4 comments · Fixed by #3594

Comments

@xrmx
Copy link
Contributor

xrmx commented Oct 4, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.20.1

Expected results

the first label in the legend is the same as the group clause

Actual results

the first group by clause label is undefined

Steps to reproduce

Create a time series bar chart with multiple group by clauses, the first will have an undefined label
@xrmx xrmx changed the title label for first group_by caluse in time series - bar chart is always undefined label for first group_by clause in time series - bar chart is always undefined Oct 4, 2017
@xrmx xrmx changed the title label for first group_by clause in time series - bar chart is always undefined label for first group by clause in time series - bar chart is always undefined Oct 4, 2017
@xrmx
Copy link
Contributor Author

xrmx commented Oct 4, 2017

Looks like a regression from 8efcaeb cc @fabianmenges

@fabianmenges
Copy link
Contributor

looking at it

@fabianmenges fabianmenges mentioned this issue Oct 4, 2017
Merged
@xrmx
Copy link
Contributor Author

xrmx commented Oct 4, 2017

@fabianmenges thanks a lot!

@fabianmenges
Copy link
Contributor

no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix]: Fixing bug in label generation for multiple groupbys tc-dc/superset
2 participants
@xrmx @fabianmenges