-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1.0.rc3] Error to download PDF or Image #30645
Comments
Hey @jacob-roldan! 👋 I'm here to help you with any bugs, questions, or becoming a contributor. Let's squash those bugs together! I found a similar open issue that might be related to the problem you're experiencing: Upon download as PDF, charts on a long dashboard render as loading image. This issue suggests that the problem might be due to the virtualization feature, which off-loads charts that are away from the viewport. A workaround is to disable the virtualization feature by updating the Superset configuration:
This change ensures that the dashboard loads all charts at once, preventing loading spinners from appearing in the downloaded PDF or image [1]. |
@geido i can't remember if i should have spun this up with a feature flag or not. |
@jacob-roldan I ran this on an instance I have and it looks like I do see that message for a bit (maybe a minute or two) but eventually the dashboard does download. How long did you wait until moving away from the dashboard? |
@sadpandajoe I can also confirm this problem using our internal test environment. 4.0.2 Screen.Recording.2024-10-17.at.16.25.03.mov4.1.0rc3 Screen.Recording.2024-10-17.at.16.24.08.mov |
Is there any configuration change between 4.0.2 and 4.1.0rc3 that is needed to generate the screenshots? |
@michael-s-molina @jacob-roldan are there any logs? We've actually been running this code on prod for a bit and haven't gotten this issue. Trying to debug this but can't seem to repro it on our end. |
@sadpandajoe @geido @eschutho I was able to pinpoint the problem. The reason for the failure is because the screenshot generation on 4.1.0 RC3 caches the screenshots using the
Talking to @villebro about this issue, he raised a good point where previously Celery workers were not a hard requirement to install Superset but more of an optional feature. If the screenshot generation always requires Celery workers from now on, that could constitute a breaking change. Let me know your thoughts. |
Thanks @michael-s-molina we are currently discussing what the next steps should be for having Celery optional and the cache. |
Bug description
Go to one Dashboard
3 dots top right / Download / Export to PDF or Download as Image
One error message is showed. See screenshot
I've tested in environment http://35.87.42.94:8080/
Screenshots/recordings
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist
The text was updated successfully, but these errors were encountered: