Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] [v1/v2] exploring a datasource throws error #2062

Closed
ascott opened this issue Jan 27, 2017 · 4 comments · Fixed by #2077
Closed

[explore] [v1/v2] exploring a datasource throws error #2062

ascott opened this issue Jan 27, 2017 · 4 comments · Fixed by #2077
Assignees
Labels
airbnb Airbnb related change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@ascott
Copy link

ascott commented Jan 27, 2017

  • i can repro this on master, on staging, but not on the latest release.

screenshot 2017-01-26 23 01 50

screenshot 2017-01-26 23 21 40

screenshot 2017-01-26 23 08 55

@bkyryliuk bkyryliuk added the airbnb Airbnb related label Jan 27, 2017
@bkyryliuk
Copy link
Member

@ascott - it is a release blocker?

@ascott
Copy link
Author

ascott commented Jan 27, 2017

@bkyryliuk yes, we shouldn't push this bug to a release.

@ascott ascott added the !deprecated-label:bug Deprecated label - Use #bug instead label Jan 27, 2017
@ascott
Copy link
Author

ascott commented Jan 27, 2017

@mistercrunch do you think this could be related to your changes ?e46ba2b#diff-3b162e04e00bcf00c104545b856a4105

@ascott ascott self-assigned this Jan 27, 2017
@ascott ascott added change:backend Requires changing the backend and removed explore-v2 labels Jan 31, 2017
@ascott
Copy link
Author

ascott commented Jan 31, 2017

this is happening on /expore/table/{id} as well as on Table View slices where there are no group by clauses.

https://github.com/ascott/superset/blob/master/superset/viz.py#L202
self.datasource.query(**query_obj) is returning a failed query with this error.

'(sqlite3.OperationalError) near "FROM": syntax error [SQL: u"SELECT\\nFROM 
birth_names\\nWHERE ds >= \'2017-01-23 21:45:44.000000\'\\n  AND ds <= \'2017-01-30 
21:45:44.000000\' LIMIT 50000\\nOFFSET 0"]'

the query it's trying to run is

SELECT\nFROM birth_names\nWHERE ds >= '2017-01-23 21:45:44.000000'\n 
AND ds <= '2017-01-30 21:45:44.000000' LIMIT 50000\nOFFSET 0

when it should be

SELECT *\nFROM birth_names\nWHERE ds >= '2017-01-23 21:45:44.000000'\n  
AND ds <= '2017-01-30 21:45:44.000000' LIMIT 50000\nOFFSET 0

this is as far as I've gotten with this one. @bkyryliuk @mistercrunch @vera-liu anyone have any ideas how to fix this? the backend is not my strong point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airbnb Airbnb related change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants