-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-Proposal]: Filter summary bar #17118
Comments
Tagging some people for discussion: @junlincc @rusackas @mihir174 @jess-dillard @kgabryje @graceguo-supercat |
I like this idea, but wonder if it becomes confusing in instances where individual charts in a dashboard have different filters applied to them. If a user sees the filter summary bar, they will likely assume all charts below the summary have those filters applied, which may not be the case. We would need one of these for every chart, which brings us close to the solution we have now. |
|
The advantages that I see with respect to this bar are the following, according to me:
|
I assume you want user to use either filter indicator or filter bar. But their functionalities are not fully matched if just looking at current description:
|
thanks for the input, I've updated the description . basically as you indicated, chart filter indicator is not useful in our usecase and we plan not to use it, but instead use the Filter summary bar for getting a quick context on what data the existing charts are displaying without really analysing filters into depth |
@amitmiran137 Can't this strategy produce wrong conclusions? I can see two examples of this: 1 - We could have two different datasets that contain the same field name City. A user creates only one filter named City for dataset 1. We have two charts, one from each dataset, and both charts can be filtered by City (different fields). When displaying the filter summary, the user will think both charts are filtered by City but in reality, only the chart that belongs to dataset 1 will be filtered. 2 - A chart contains an incompatible filter. When displaying the filter summary, the user will think the chart is filtered when it's not, leading to wrong conclusions. |
Perhaps it would be possible to have something like this:
|
If we do something like this, we would need to display a tooltip or text to let the user know that they can hover and that the summary is not accurate when not hovering.
Wouldn't this practically replace/duplicate the filter indicators? |
In airbnb when we design Filter Indicator, |
IMO the summary bar is just a display of the active filters in cases where you want to show the user the context that he is viewing . |
Hi @amitmiran137 a pretty big feature like this one, should we start SIP first? Superset is an open source project, but it also has its own roadmap. Is this feature aligned with dashboard |
@graceguo-supercat What is the dashboard resign you're referring to ? It is just a separated component that can optionally be dragged into the dashboard and has no effect beside showing a summary of the active filters Look at the the PR link to this feature to see a demo on the behaviour . |
sorry, not |
closing this one due to an improved solution and SIP |
As a continuation feature to the native-filters left side panel there is a requirement on focusing users on charts by a specific user-path in watch a short summary for the current active filters that applies the current scope in order to make the dashboard more readable oriented in the cases where dashboards are served as a client-facing application.
For that we offer the Filter summary bar which it is another element that can be dragged into the dashboard layout (as charts, tabs , column ,row and etc') , which means it would be optional to use in each dashboard
prototype
Figma
key features:
note: we might consider hiding(CSS) those chart filter indicators in order to focus the user on visualization themself but that is for the dashboard creator to decide on each dashboard separately
backward compatibility:
if you don't drag the filter summary bar into the dashboard feature will not be used at all and existing functionality remains intact
dashboard preview:
Summary Filter bar component
The text was updated successfully, but these errors were encountered: