Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filter] dataset/column/advanced element disappears from the "Filters configuration and scoping" modal when user undo deleting native filter #16821

Closed
2 of 3 tasks
jinghua-qa opened this issue Sep 23, 2021 · 0 comments · Fixed by #16851
Assignees
Labels
#bug Bug report P1 Priority item - Major preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

jinghua-qa commented Sep 23, 2021

Dataset/column/advanced elements disappears from the "Filters configuration and scoping" modal when user undo deleting native filter

How to reproduce the bug

1, Open the dashboard from preconditions
2, Expand the "Native filter" panel
3, Click the "Pencil" icon
4, Click the "Delete" icon next to the native filter (from preconditions)
5, Click the "Undo" button
6, See key sections are missing in the modal

Expected results

Dataset/column/advanced elements did not disappear when undo delete

Actual results

Dataset/column/advanced elements disappear when undo delete

Screenshots

CleanShot.2021-09-23.at.15.34.54.mp4

Environment

(please complete the following information):

  • browser type and version:
  • superset version: latest master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report P1 Priority item - Major preset:QA Preset QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants