Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnd][dnd hybrid] reordering by dnd is not accurate and popover is not matching when the reordering fail #16317

Closed
2 of 3 tasks
jinghua-qa opened this issue Aug 18, 2021 · 0 comments · Fixed by #16322
Closed
2 of 3 tasks
Assignees
Labels
#bug Bug report preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

This issue is observed in dnd mode and dnd hybrid mode
When doing reordering for multiple times with dnd, it become inaccurate and moving one metric sometimes was moving other metric, and when the reordering behavior is incorrect, the popover is not matching the column and metrics.

Expected results

reordering is accurate and popover will match the metric after reordering

Actual results

reordering is not accurate and popover did not match the metric after reordering is wrong

Screenshots

[dnd hybrid FF] reordering issue

dnd.hybrid.reordering.not.accurate.mov

[dnd FF only] reordering issue and popover did not match up with metric once the reordering is wrong

dnd.reordering.issue.1.mov

How to reproduce the bug

  1. add multiple metric or columns to fields
  2. reordering multiple times by dnd
  3. observe reordering error
  4. when ordering error is observed, check popover for metrics

Environment

(please complete the following information):

  • superset version: latest master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:QA Preset QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants