Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqllab results columns are not sortable for large number of columns #16261

Closed
3 tasks done
michellethomas opened this issue Aug 14, 2021 · 10 comments
Closed
3 tasks done
Assignees
Labels
#bug Bug report good first issue Good first issues for new contributors inactive Inactive for >= 30 days sqllab Namespace | Anything related to the SQL Lab

Comments

@michellethomas
Copy link
Contributor

For a sqllab query that returns a large number of columns (I observed this in a query with ~70 columns), the sorting functionality is broken. Columns do not sort at all.

I'm not sure how easy this is to fix. Do we want to consider this a limitation of sqllab or is this fixable?

Expected results

Columns have the ability to sort

Actual results

When you click on the column header it does not sort and does not show the sorting arrow

How to reproduce the bug

  1. Go to sqllab and run a query with 70 columns
  2. Try to sort the results

Environment

(please complete the following information):

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michellethomas michellethomas added sqllab Namespace | Anything related to the SQL Lab #bug Bug report labels Aug 14, 2021
@averma111
Copy link

I will have a look into it

@junlincc junlincc added the good first issue Good first issues for new contributors label Aug 16, 2021
@junlincc
Copy link
Member

Similar issue happened before when # of columns is over 60is, i remember. @averma111 thanks for volunteering, let us know if you need help :)

@averma111
Copy link

@junlincc sure I will let you know.

@averma111
Copy link

@junlincc and @yousoph I am looking at superset-frontend--->src-->components-->SqlLab-->QueryTable-->Index.jsx file, for object modalTitle={t('Data preview')} to check if the sorting arrow is poping up for table less then 50 columns.

@etr2460
Copy link
Member

etr2460 commented Aug 27, 2021

Hi @averma111 , any update on your investigation here?

@averma111
Copy link

@etr2460 I am working on finding the issue with UI of the super set. Give me couple of days

@etr2460
Copy link
Member

etr2460 commented Sep 24, 2021

Hi @averma111 were you able to find the issue/are you still working on this issue?

@averma111
Copy link

@etr2460 my apologies I didnt get time to work on this bug.I am pulling out my self.

@averma111 averma111 removed their assignment Oct 4, 2021
@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 18, 2022
@rusackas
Copy link
Member

Looks like this was resolved without being auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report good first issue Good first issues for new contributors inactive Inactive for >= 30 days sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

No branches or pull requests

6 participants