Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alert/report] Solution for dashboards with multiple tabs #14056

Closed
zuzana-vej opened this issue Apr 9, 2021 · 9 comments
Closed

[alert/report] Solution for dashboards with multiple tabs #14056

zuzana-vej opened this issue Apr 9, 2021 · 9 comments
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature enhancement:request Enhancement request submitted by anyone from the community

Comments

@zuzana-vej
Copy link
Contributor

zuzana-vej commented Apr 9, 2021

Current situation / Problem statement
Current Reporting solution only sends out the 1st dashboard tab. Dashboards can have multiple tabs as well as nested tabs (up to 3 levels of nested tabs are allowed). Within our user base, at least ~15% of dashboards have tabs.

The workaround for users is either to put all the charts they want to receive via emailed on 1st tab, or create multiple dashboards just for the email report purpose. Some users do this, causing potentially clutter (many dashboards instead of one), making discoverability of the correct dashboard harder, and and making maintenance harder.

User requirement:

  1. Ability to select which tab to send
  2. Ability to send multiple tabs in a single email

Rejected solutions

  1. Send all tabs; This can have negative performance implications; some dashboards are large (many tabs) and some dashboard producers create tab just for old / deprecated charts, and those should never be send out.

Proposed solution
Enable user to select which tabs to be send out; User can select more than one tab. The email will contain multiple screenshots, in the order of most top level / most left tab as if user was browsing the dashboard.

Discussion points

  1. Should there be an upper limit to how many tabs user can select to send within a single email?
  2. UI/UX
@zuzana-vej zuzana-vej added alert-reports Namespace | Anything related to the Alert & Reports feature enhancement:request Enhancement request submitted by anyone from the community labels Apr 9, 2021
@zuzana-vej
Copy link
Contributor Author

Update: We are planning to prioritize this feature at some point late Q2/earlyQ3, but keeping this GH# open as a space for discussion (to enable this tab specific discussion separately from the #13954

@zuzana-vej zuzana-vej changed the title [Reporting] Solution for dashboards with multiple tabs [alert/report] Solution for dashboards with multiple tabs Oct 20, 2021
@zuzana-vej
Copy link
Contributor Author

zuzana-vej commented Oct 20, 2021

Few data points from Airbnb Email Report users:
~50 users; 11 responded a survey; 65% of users would use this feature immediately; 75% plan to only send multiple top level tab; 25% would use it for specifying a nested tabs to be send out.
Users would like to send different tabs to different recipients (= can be satisfied as multiple report configurations).

@zuzana-vej
Copy link
Contributor Author

Would love some design inputs on how to enable users to select multiple tabs which can then be attached to a single email report. Options we thought about:

  1. multiple drop down boxes
    -- OK for one tab, but might be complicated for multiple tabs)

  2. tabs combinations can be fully spelled out in a single dropdown and user can select 1+ items from the dropdown
    Example (sample dashboard):

Screen Shot 2021-10-18 at 1 17 42 PM

Dropdown would have values:
  1. Summary
  2. Deep Dive | Summary
  3. Deep Dive | Page Load Duration
  4. Deep Dive | Usage Details
  5. Deep Dive | Error Details
  6. Deep Dive | Cache and Query Time

Would love some inputs from @jess-dillard / @mihir174 / @yousoph
(Cc @graceguo-supercat, @m-ajay)

@ghost
Copy link

ghost commented Oct 20, 2021

Have you considered checkboxes? Nested tabs could be represented as indented checkboxes, where the top-level checkbox could control all beneath it.

@zuzana-vej
Copy link
Contributor Author

There are two ways how user can get to Email report modal configuration - user has 2 ways to enter into the "editing report" flow.

1. From dashboard:

  • User is on dashboard and clicks on the icon in top right corner. User might are viewing dashbord in this moment and are seeing specific tabs combination when they click on the report icon.
  • The report will get configured for the current tabs user is viewing.
  • User will see an information configuring report for currently selected tabs --> the proposal is to add this text above "REPORT NAME" textbox on the modal
  • There is no need to add tab selector into the modal, because user will be configuring for the currently visible tabs

modal-1

2. From "Settings > Alerts&Reports"

  • User can enter the report configuration from "Settings > Alerts&Reports" and click "+Alert" button.
  • The complex new report modal shows up and in this modal, user will be able to select the tabs to be sent out

modal-2

The experience to select tabs will be like tree style check boxes to display the tabs hierarchy, similarly like filter scopes:
Screen Shot 2021-11-03 at 10 16 08 AM

  • User can select any number of child tabs
  • Is user selects a top level tab (or a tab which still has child tabs), by default only the child top level tab will get selected. (reason (1) mimic experience of viewing dashboard; (2) to prevent too many screenshots of dashboard unless needed as indicated by user)
  • If user wants to send all child level tabs of a specific top level tab, they can manually check all the child checkboxes.

Limits:
Currently no plans to limit how many tabs user can select; if there are performance issues, we will revisit this area and add a warning or config variable to limit the tabs user can send.

Please share if you have any feedback to the plan. @jess-dillard @yousoph

@graceguo-supercat
Copy link

graceguo-supercat commented Nov 4, 2021

I agree @zuzana-vej's proposal, just 1 small suggestion:
For case 1 From dashboard:
instead of enforcing report on the current selected tab, give user an option: report default dashboard (by default), or report current selected tab. The UI could be similar to filter component scope configuration:
Screen Shot 2021-11-04 at 10 11 44 AM
This behavior will be consistent with current dashboard report behavior: by default, report the first tab (and its first children tabs).

Similarly for case 2 From "Settings > Alerts&Reports"
Also add an option: report default dashboard (by default), or select a tab. If user choose select a dashboard tab, then show the dashboard tabs tree.
cc @zuzana-vej

@yousoph
Copy link
Member

yousoph commented Nov 4, 2021

This is great! The proposal makes sense to me, @zuzana-vej and I like @graceguo-supercat 's suggestion of giving the user more information and choice when setting up a report.

I'd also suggest allowing users from the dashboard to select multiple tabs for their report. Maybe by default the report is for the current tab but they can select the default dashboard or additional tabs as well?

@zuzana-vej
Copy link
Contributor Author

@yousoph thanks for the suggestions; it can be done.

Different question - what was the initial thinking behind having tow different modals based on user entry point? The one from Settings is much more details which is why we though the multiple tabs is a detail setting and therefore can be on the details modal.

I am unsure how many users know that exists and whether a note on the modal they get when entering from Dashboard, saying something like More detailed settings, like multiple owners, conditional alert, or multiple tabs, is available from Settings > Alerts & Reports.

@graceguo-supercat
Copy link

Hi @yousoph I also prefer Zuzana's proposal: set default or selected tab as selected report tab inside a dashboard's report menu, and show tab selector in the report detail menu.

When setup report schedule, I feel people want to make sure they are sending out the right tab, so they want to verify it in the dashboard during the setup schedule.

  • In dashboard, users are easy to navigate to the right place, and set. So inside dashboard, create a new selector and ask user to choose a tab to report, seems not necessary.

  • In report detail page, preview dashboard is a little harder, so ppl probably to open a dashboard in other browser and check it. But probably we don't have better way for user to preview selected tab inside report menu.

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18475 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
alert-reports Namespace | Anything related to the Alert & Reports feature enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

3 participants