diff --git a/Makefile b/Makefile index 8ce0a0b8b99e4..14e7bb17efdac 100644 --- a/Makefile +++ b/Makefile @@ -93,7 +93,7 @@ py-lint: pre-commit js-format: cd superset-frontend; npm run prettier -flask-app: activate +flask-app: flask run -p 8088 --with-threads --reload --debugger node-app: @@ -115,31 +115,3 @@ report-celery-beat: admin-user: superset fab create-admin - -# Create a postgres instance using docker -# CLI: $ psql postgresql://postgres:1234@localhost:5432/postgres -# superset_config.py: SQLALCHEMY_DATABASE_URI = 'postgresql://postgres:1234@localhost:5432/postgres' -db: - # start postgres with detached mode - docker run -d -p 127.0.0.1:5432:5432 -e POSTGRES_PASSWORD="1234" --name pg postgres:alpine;\ - EXIT_CODE=$$?;\ - echo $$EXIT_CODE;\ - echo "command exited with $$EXIT_CODE";\ - if [ $$EXIT_CODE -ne "0" ]; then docker start pg; echo "DB has been created"; fi - -db-stop: - docker stop pg - -cache: - docker run -d --name redis-stack-server -p 6379:6379 redis/redis-stack-server:latest;\ - EXIT_CODE=$$?;\ - echo $$EXIT_CODE;\ - echo "command exited with $$EXIT_CODE";\ - if [ $$EXIT_CODE -ne "0" ]; then docker start redis-stack-server; echo "cache has been created"; fi - -cache-stop: - docker stop redis-stack-server - -# Primarily made for GH codespaces but this flow could work on your local as well -api: db cache flask-app -client: node-app diff --git a/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx b/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx index bfd322c8babdf..7b52eab26ca22 100644 --- a/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx +++ b/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx @@ -31,27 +31,24 @@ export const hostField = ({ getValidation, validationErrors, db, -}: FieldPropTypes) => { - debugger; - return ( - - ); -}; +}: FieldPropTypes) => ( + +); export const portField = ({ required, diff --git a/superset-frontend/src/features/databases/DatabaseModal/index.tsx b/superset-frontend/src/features/databases/DatabaseModal/index.tsx index c6e73de4e699c..dd2e405350056 100644 --- a/superset-frontend/src/features/databases/DatabaseModal/index.tsx +++ b/superset-frontend/src/features/databases/DatabaseModal/index.tsx @@ -249,8 +249,6 @@ export function dbReducer( let actionPayloadJson; const extraJson: ExtraJson = JSON.parse(trimmedState.extra || '{}'); - console.log(action.type); - switch (action.type) { case ActionType.extraEditorChange: // "extra" payload in state is a string