From b12f515185c3555b7576a944eb250859e9fbc23a Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Wed, 29 Jan 2025 23:29:30 -0800
Subject: [PATCH] fix: re-enable cypress checks (#32008)

---
 .gitignore                                                | 1 +
 scripts/cypress_run.py                                    | 1 +
 .../cypress-base/cypress/e2e/dashboard/drillby.test.ts    | 2 +-
 .../cypress/e2e/dashboard/drilltodetail.test.ts           | 8 ++++----
 .../cypress/e2e/dashboard/horizontalFilterBar.test.ts     | 6 +++---
 5 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index 67bc771f84c1a..e8714d70ab3b1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -21,6 +21,7 @@
 *.swp
 __pycache__
 
+.aider.*
 .local
 .cache
 .bento*
diff --git a/scripts/cypress_run.py b/scripts/cypress_run.py
index 7531aad8dafa3..33984995cee94 100644
--- a/scripts/cypress_run.py
+++ b/scripts/cypress_run.py
@@ -60,6 +60,7 @@ def run_cypress_for_test_file(
                 f"--browser {browser} "
                 f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
                 f"--ci-build-id {build_id} "
+                f"--wait-for-missing-groups "
                 f"-- {chrome_flags}"
             )
         else:
diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
index e471d1da8caa2..c4c5ed47665fb 100644
--- a/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
+++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
@@ -599,7 +599,7 @@ describe('Drill by modal', () => {
       ]);
     });
 
-    it.skip('Radar Chart', () => {
+    it('Radar Chart', () => {
       testEchart('radar', 'Radar Chart', [
         [182, 49],
         [423, 91],
diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
index 4ebd64dd6e501..f11aac445446b 100644
--- a/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
+++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
@@ -335,7 +335,7 @@ describe('Drill to detail modal', () => {
       });
     });
 
-    describe.skip('Bar Chart', () => {
+    describe('Bar Chart', () => {
       it('opens the modal with the correct filters', () => {
         interceptSamples();
 
@@ -373,7 +373,7 @@ describe('Drill to detail modal', () => {
       });
     });
 
-    describe.skip('Area Chart', () => {
+    describe('Area Chart', () => {
       it('opens the modal with the correct filters', () => {
         testTimeChart('echarts_area');
       });
@@ -407,7 +407,7 @@ describe('Drill to detail modal', () => {
       });
     });
 
-    describe.skip('World Map', () => {
+    describe('World Map', () => {
       it('opens the modal with the correct filters', () => {
         interceptSamples();
 
@@ -567,7 +567,7 @@ describe('Drill to detail modal', () => {
       });
     });
 
-    describe.skip('Radar Chart', () => {
+    describe('Radar Chart', () => {
       it('opens the modal with the correct filters', () => {
         interceptSamples();
 
diff --git a/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts b/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
index bcacae8a36dbc..f1bfa9617e1c3 100644
--- a/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
+++ b/superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
@@ -176,7 +176,7 @@ describe('Horizontal FilterBar', () => {
     validateFilterNameOnDashboard(testItems.topTenChart.filterColumn);
   });
 
-  it.skip('should spot changes in "more filters" and apply their values', () => {
+  it('should spot changes in "more filters" and apply their values', () => {
     cy.intercept(`/api/v1/chart/data?form_data=**`).as('chart');
     prepareDashboardFilters([
       { name: 'test_1', column: 'country_name', datasetId: 2 },
@@ -204,7 +204,7 @@ describe('Horizontal FilterBar', () => {
     );
   });
 
-  it.skip('should focus filter and open "more filters" programmatically', () => {
+  it('should focus filter and open "more filters" programmatically', () => {
     prepareDashboardFilters([
       { name: 'test_1', column: 'country_name', datasetId: 2 },
       { name: 'test_2', column: 'country_code', datasetId: 2 },
@@ -231,7 +231,7 @@ describe('Horizontal FilterBar', () => {
     cy.get('.ant-select-focused').should('be.visible');
   });
 
-  it.skip('should show tag count and one plain tag on focus and only count on blur in select ', () => {
+  it('should show tag count and one plain tag on focus and only count on blur in select ', () => {
     prepareDashboardFilters([
       { name: 'test_1', column: 'country_name', datasetId: 2 },
     ]);