From a9952bb4492b86192a39a669e2d35d969d56c3dd Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Wed, 5 Sep 2018 13:46:04 -0700 Subject: [PATCH] [SIP-5] Remove unused function #easy-review (#5825) * remove unused function * remove comment --- superset/assets/src/chart/Chart.jsx | 4 ---- superset/assets/src/visualizations/table.js | 4 ---- 2 files changed, 8 deletions(-) diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx index b93b2758bbc06..a9dd0ff3b7a20 100644 --- a/superset/assets/src/chart/Chart.jsx +++ b/superset/assets/src/chart/Chart.jsx @@ -170,10 +170,6 @@ class Chart extends React.PureComponent { this.props.actions.chartRenderingFailed(e, this.props.chartId); } - verboseMetricName(metric) { - return this.props.datasource.verbose_map[metric] || metric; - } - renderTooltip() { if (this.state.tooltip) { return ( diff --git a/superset/assets/src/visualizations/table.js b/superset/assets/src/visualizations/table.js index 1e09b834022b3..a875aad655832 100644 --- a/superset/assets/src/visualizations/table.js +++ b/superset/assets/src/visualizations/table.js @@ -288,10 +288,6 @@ function adaptor(slice, payload) { orderDesc, pageLength: pageLength && parseInt(pageLength, 10), percentMetrics, - // Aug 22, 2018 - // Perhaps this `tableFilter` field can be removed as there is - // no code left in repo to set tableFilter to true. - // which make `onAddFilter` will never be called as well. tableFilter, tableTimestampFormat, timeseriesLimitMetric,