From 7a86b5324bf811ea7b309cf4452ed39184168f84 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Wed, 29 Aug 2018 15:41:28 -0700 Subject: [PATCH] update proptypes and add comments --- superset/assets/src/visualizations/pivot_table.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/superset/assets/src/visualizations/pivot_table.js b/superset/assets/src/visualizations/pivot_table.js index 4f6def0761535..cd93867cbfdb4 100644 --- a/superset/assets/src/visualizations/pivot_table.js +++ b/superset/assets/src/visualizations/pivot_table.js @@ -9,6 +9,7 @@ dt(window, $); const propTypes = { data: PropTypes.shape({ + // TODO: replace this with raw data in SIP-6 html: PropTypes.string, columns: PropTypes.arrayOf(PropTypes.oneOfType([ PropTypes.string, @@ -16,10 +17,10 @@ const propTypes = { ])), }), height: PropTypes.number, - columnFormats: PropTypes.object, + columnFormats: PropTypes.objectOf(PropTypes.string), groupBy: PropTypes.arrayOf(PropTypes.string), numberFormat: PropTypes.string, - verboseMap: PropTypes.object, + verboseMap: PropTypes.objectOf(PropTypes.string), }; function PivotTable(element, props) {