Skip to content

Commit 7a2d4f5

Browse files
Addresses comments
1 parent 327d9e1 commit 7a2d4f5

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

UPDATING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ assists people when migrating to a new version.
4343
- [26637](https://github.com/apache/superset/issues/26637): Sets the `DRILL_BY` feature flag to `True` by default given that the feature has been tested for a while and reached a stable state.
4444
- [26462](https://github.com/apache/superset/issues/26462): Removes the Profile feature given that it's not actively maintained and not widely used.
4545
- [26377](https://github.com/apache/superset/pull/26377): Removes the deprecated Redirect API that supported short URLs used before the permalink feature.
46-
- [X](https://github.com/apache/superset/issues/X): Removes the deprecated `DASHBOARD_NATIVE_FILTERS` feature flag. The previous value of the feature flag was `True` and now the feature is permanently enabled.
46+
- [26329](https://github.com/apache/superset/issues/26329): Removes the deprecated `DASHBOARD_NATIVE_FILTERS` feature flag. The previous value of the feature flag was `True` and now the feature is permanently enabled.
4747

4848
### Potential Downtime
4949

superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx

+13-17
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,9 @@ import React from 'react';
2121
import {
2222
ChartDataResponseResult,
2323
ensureIsArray,
24-
FeatureFlag,
2524
GenericDataType,
2625
hasGenericChartAxes,
2726
isAdhocColumn,
28-
isFeatureEnabled,
2927
isPhysicalColumn,
3028
QueryFormColumn,
3129
QueryMode,
@@ -290,21 +288,19 @@ const config: ControlPanelConfig = {
290288
},
291289
},
292290
],
293-
isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS)
294-
? [
295-
{
296-
name: 'server_pagination',
297-
config: {
298-
type: 'CheckboxControl',
299-
label: t('Server pagination'),
300-
description: t(
301-
'Enable server side pagination of results (experimental feature)',
302-
),
303-
default: false,
304-
},
305-
},
306-
]
307-
: [],
291+
[
292+
{
293+
name: 'server_pagination',
294+
config: {
295+
type: 'CheckboxControl',
296+
label: t('Server pagination'),
297+
description: t(
298+
'Enable server side pagination of results (experimental feature)',
299+
),
300+
default: false,
301+
},
302+
},
303+
],
308304
[
309305
{
310306
name: 'row_limit',

0 commit comments

Comments
 (0)