diff --git a/UPDATING.md b/UPDATING.md index 0c72d78faaa9e..b398bff1c24b1 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -37,7 +37,7 @@ assists people when migrating to a new version. - [18970](https://github.com/apache/superset/pull/18970): Changes feature flag for the legacy datasource editor (DISABLE_LEGACY_DATASOURCE_EDITOR) in config.py to True, thus disabling the feature from being shown in the client. - [19017](https://github.com/apache/superset/pull/19017): Removes Python 3.7 support. -- [19142](https://github.com/apache/superset/pull/19142): Changes feature flag for versioned export(VERSIONED_EXPORT) to be true, depreciating older api endpoints. +- [19142](https://github.com/apache/superset/pull/19142): Changes feature flag for versioned export(VERSIONED_EXPORT) to be true. ### Potential Downtime diff --git a/tests/integration_tests/cli_tests.py b/tests/integration_tests/cli_tests.py index ac7ba23c55481..7426d90ea88af 100644 --- a/tests/integration_tests/cli_tests.py +++ b/tests/integration_tests/cli_tests.py @@ -97,7 +97,6 @@ def test_export_datasources_original(app_context, fs): ) assert response.exit_code == 0 - # this api is deprecated, so it shows a response of 1 instead of 0 assert Path("datasources.yaml").exists() diff --git a/tests/integration_tests/dashboards/api_tests.py b/tests/integration_tests/dashboards/api_tests.py index 7ec5b9f6b3fdc..2ed627a257247 100644 --- a/tests/integration_tests/dashboards/api_tests.py +++ b/tests/integration_tests/dashboards/api_tests.py @@ -1331,6 +1331,11 @@ def test_update_dashboard_not_owned(self): db.session.delete(user_alpha2) db.session.commit() + @patch.dict( + "superset.extensions.feature_flag_manager._feature_flags", + {"VERSIONED_EXPORT": False}, + clear=True, + ) @pytest.mark.usefixtures( "load_world_bank_dashboard_with_slices", "load_birth_names_dashboard_with_slices", @@ -1346,9 +1351,7 @@ def test_export(self): # freeze time to ensure filename is deterministic with freeze_time("2020-01-01T00:00:00Z"): rv = self.get_assert_metric(uri, "export") - headers = generate_download_headers( - "zip", "dashboard_export_20200101T000000" - )["Content-Disposition"] + headers = generate_download_headers("json")["Content-Disposition"] assert rv.status_code == 200 assert rv.headers["Content-Disposition"] == headers @@ -1378,11 +1381,6 @@ def test_export_not_allowed(self): db.session.delete(dashboard) db.session.commit() - @patch.dict( - "superset.extensions.feature_flag_manager._feature_flags", - {"VERSIONED_EXPORT": True}, - clear=True, - ) def test_export_bundle(self): """ Dashboard API: Test dashboard export @@ -1398,11 +1396,6 @@ def test_export_bundle(self): buf = BytesIO(rv.data) assert is_zipfile(buf) - @patch.dict( - "superset.extensions.feature_flag_manager._feature_flags", - {"VERSIONED_EXPORT": True}, - clear=True, - ) def test_export_bundle_not_found(self): """ Dashboard API: Test dashboard export not found @@ -1413,11 +1406,6 @@ def test_export_bundle_not_found(self): rv = self.client.get(uri) assert rv.status_code == 404 - @patch.dict( - "superset.extensions.feature_flag_manager._feature_flags", - {"VERSIONED_EXPORT": True}, - clear=True, - ) def test_export_bundle_not_allowed(self): """ Dashboard API: Test dashboard export not allowed diff --git a/tests/integration_tests/datasets/api_tests.py b/tests/integration_tests/datasets/api_tests.py index eeda824500fe6..7626de677bf01 100644 --- a/tests/integration_tests/datasets/api_tests.py +++ b/tests/integration_tests/datasets/api_tests.py @@ -1455,11 +1455,6 @@ def test_export_dataset_gamma(self): rv = self.client.get(uri) assert rv.status_code == 200 - @patch.dict( - "superset.extensions.feature_flag_manager._feature_flags", - {"VERSIONED_EXPORT": True}, - clear=True, - ) @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices") def test_export_dataset_bundle(self): """ @@ -1482,11 +1477,6 @@ def test_export_dataset_bundle(self): buf = BytesIO(rv.data) assert is_zipfile(buf) - @patch.dict( - "superset.extensions.feature_flag_manager._feature_flags", - {"VERSIONED_EXPORT": True}, - clear=True, - ) def test_export_dataset_bundle_not_found(self): """ Dataset API: Test export dataset not found @@ -1499,11 +1489,6 @@ def test_export_dataset_bundle_not_found(self): assert rv.status_code == 404 - @patch.dict( - "superset.extensions.feature_flag_manager._feature_flags", - {"VERSIONED_EXPORT": True}, - clear=True, - ) @pytest.mark.usefixtures("create_datasets") def test_export_dataset_bundle_gamma(self): """