test: fix flaky Python unit tests (#12253)

Author: kstrz

tests/databases/api_tests.py

@@ -19,6 +19,7 @@
 """Unit tests for Superset"""
 import json
 from io import BytesIO
+from unittest import mock
 from zipfile import is_zipfile, ZipFile
 
 import prison
@@ -343,6 +344,10 @@ def test_create_database_uri_validate(self):
             "Invalid connection string", response["message"]["sqlalchemy_uri"][0],
         )
 
+    @mock.patch(
+        "superset.views.core.app.config",
+        {**app.config, "PREVENT_UNSAFE_DB_CONNECTIONS": True},
+    )
     def test_create_database_fail_sqllite(self):
         """
         Database API: Test create fail with sqllite
@@ -493,6 +498,9 @@ def test_update_database_uri_validate(self):
             "Invalid connection string", response["message"]["sqlalchemy_uri"][0],
         )
 
+        db.session.delete(test_database)
+        db.session.commit()
+
     def test_delete_database(self):
         """
         Database API: Test delete
@@ -830,6 +838,8 @@ def test_test_connection_unsafe_uri(self):
         }
         self.assertEqual(response, expected_response)
 
+        app.config["PREVENT_UNSAFE_DB_CONNECTIONS"] = False
+
     @pytest.mark.usefixtures(
         "load_unicode_dashboard_with_position", "load_energy_table_with_slice"
     )

tests/db_engine_specs/base_engine_spec_tests.py

@@ -170,6 +170,8 @@ def test_time_grain_addons(self):
             time_grain_addon = time_grains[-1]
             self.assertEqual("PTXM", time_grain_addon.duration)
             self.assertEqual("x seconds", time_grain_addon.label)
+            app.config["TIME_GRAIN_ADDONS"] = {}
+            app.config["TIME_GRAIN_ADDON_EXPRESSIONS"] = {}
 
     def test_engine_time_grain_validity(self):
         time_grains = set(builtin_time_grains.keys())

tests/email_tests.py

@@ -36,7 +36,7 @@
 
 class TestEmailSmtp(SupersetTestCase):
     def setUp(self):
-        app.config["smtp_ssl"] = False
+        app.config["SMTP_SSL"] = False
 
     @mock.patch("superset.utils.core.send_mime_email")
     def test_send_smtp(self, mock_send_mime):
@@ -150,6 +150,8 @@ def test_send_mime_ssl(self, mock_smtp, mock_smtp_ssl):
     @mock.patch("smtplib.SMTP_SSL")
     @mock.patch("smtplib.SMTP")
     def test_send_mime_noauth(self, mock_smtp, mock_smtp_ssl):
+        smtp_user = app.config["SMTP_USER"]
+        smtp_password = app.config["SMTP_PASSWORD"]
         app.config["SMTP_USER"] = None
         app.config["SMTP_PASSWORD"] = None
         mock_smtp.return_value = mock.Mock()
@@ -158,6 +160,8 @@ def test_send_mime_noauth(self, mock_smtp, mock_smtp_ssl):
         assert not mock_smtp_ssl.called
         mock_smtp.assert_called_with(app.config["SMTP_HOST"], app.config["SMTP_PORT"])
         assert not mock_smtp.login.called
+        app.config["SMTP_USER"] = smtp_user
+        app.config["SMTP_PASSWORD"] = smtp_password
 
     @mock.patch("smtplib.SMTP_SSL")
     @mock.patch("smtplib.SMTP")

tests/queries/api_tests.py

@@ -179,13 +179,16 @@ def test_get_query_not_found(self):
         """
         admin = self.get_user("admin")
         client_id = self.get_random_string()
-        self.insert_query(get_example_database().id, admin.id, client_id)
+        query = self.insert_query(get_example_database().id, admin.id, client_id)
         max_id = db.session.query(func.max(Query.id)).scalar()
         self.login(username="admin")
         uri = f"api/v1/query/{max_id + 1}"
         rv = self.client.get(uri)
         self.assertEqual(rv.status_code, 404)
 
+        db.session.delete(query)
+        db.session.commit()
+
     def test_get_query_no_data_access(self):
         """
         Query API: Test get query without data access

tests/queries/saved_queries/api_tests.py

@@ -534,6 +534,8 @@ def test_get_saved_query_not_found(self):
         uri = f"api/v1/saved_query/{max_id + 1}"
         rv = self.client.get(uri)
         assert rv.status_code == 404
+        db.session.delete(query)
+        db.session.commit()
 
     def test_create_saved_query(self):
         """

tests/security_tests.py

@@ -260,6 +260,7 @@ def test_set_perm_sqla_table(self):
         session.commit()
 
     def test_set_perm_druid_datasource(self):
+        self.create_druid_test_objects()
         session = db.session
         druid_cluster = (
             session.query(DruidCluster).filter_by(cluster_name="druid_test").one()