Deploy swck snapshot charts #112
Conversation
|
Why is the helm going to have snapshot now? I don't think we have changes for this frequently. |
|
| @@ -14,7 +14,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
| apiVersion: v2 | |||
| name: skywalking-swck-operator | |||
| name: skywalking-helm-swck-operator | |||
There was a problem hiding this comment.
We will publish these to hub.docker.io, and to make it clear this is a Helm Chart, not a Docker image, I change the names to be prefixed with skywalking-helm-*, and will ask infra team to create the repositories with the same name prefix
There was a problem hiding this comment.
So, this is a helm for swck?
Yes, as the title indicates. swck contains two Helm Charts actually, namely, operator and adapter
There was a problem hiding this comment.
Can't dockerhub directly know that this is a chart type?
There was a problem hiding this comment.
Can't dockerhub directly know that this is a chart type?
Of course it knows, I meant I want to make it clear for our users.
There was a problem hiding this comment.
@innerpeacez I think here is about avoiding confusion of another existing repo, https://hub.docker.com/r/apache/skywalking-swck
| @@ -23,6 +23,7 @@ on: | |||
|
|
|||
| env: | |||
| HUB: ghcr.io/apache/skywalking-kubernetes | |||
| VERSION: 0.0.0-${{ github.sha }} | |||
There was a problem hiding this comment.
As a snapshot, could we have a version prefix?
There was a problem hiding this comment.
As a snapshot, could we have a version prefix?
like this -snapshot?
There was a problem hiding this comment.
As a snapshot, could we have a version prefix?
We never have this suffix in all our existing snapshot Docker images, do we want to add it from now?
There was a problem hiding this comment.
prefix, I mean, such as 4.5.0-xxxx
There was a problem hiding this comment.
prefix, I mean, such as 4.5.0-xxxx
Sure. the rationale here I use 0.0.0-xxx is that, to mimic the same version style as our existing snapshot Docker images, whose version is simply <sha>, without a version prefix like 9.5.0-<sha>, when we want to use a snapshot of a particular commit in the main branch, we don't have to find out what version is it currently, we can just copy the commit sha and use it 0.0.0-<sha>.
The
0.0.0-prefix is just to adhere the version format of Helm Chart, it must be\d+.\d+.\d-\w+style.
I actually have this idea, when I use otel. |
No description provided.