Atomikos XA transaction started when it is not configured in server.yaml #18894

sandynz · 2022-07-06T08:11:25Z

Bug Report

Which version of ShardingSphere did you use?

master branch, 0b41852

Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?

Proxy

Expected behavior

XA transaction won't be started.

Actual behavior

It started.

Reason analyze (If you can)

In GlobalRulesBuilder:

In XAShardingSphereTransactionManager:
Since AtomikosTransactionManagerProvider is the default impl of XATransactionManagerProvider, XATransactionManagerProviderFactory.getInstance(null) in XAShardingSphereTransactionManager.init return AtomikosTransactionManagerProvider instance.

Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.

server.yaml:

mode:
  type: Cluster
  repository:
    type: ZooKeeper
    props:
      namespace: mysql
      server-lists: localhost:2181
      retryIntervalMilliseconds: 500
      timeToLiveSeconds: 60
      maxRetries: 3
      operationTimeoutMilliseconds: 500
  overwrite: false

rules:
  - !AUTHORITY
    users:
      - root@%:root
      - sharding@:sharding
    provider:
      type: ALL_PERMITTED
#  - !TRANSACTION
#    defaultType: XA
#    providerType: Atomikos
  - !SQL_PARSER
    sqlCommentParseEnabled: true
    sqlStatementCache:
      initialCapacity: 2000
      maximumSize: 65535
    parseTreeCache:
      initialCapacity: 128
      maximumSize: 1024

Global rules in ZK after Proxy 3307 started:

- !AUTHORITY
  provider:
    type: ALL_PERMITTED
  users:
  - root@%:root
  - sharding@%:sharding
- !SQL_PARSER
  parseTreeCache:
    initialCapacity: 128
    maximumSize: 1024
  sqlCommentParseEnabled: true
  sqlStatementCache:
    initialCapacity: 2000
    maximumSize: 65535

1, Start Proxy with 3307 port

2, Start another Proxy with 3308 port

The second one will start failed with exception:

[ERROR] 2022-07-06 15:16:50.805 [main] c.a.persistence.imp.LogFileLock - The specified log seems to be in use already: xa_tx in ./logs/. Make sure that no other instance is running, or kill any pending process if needed.
Exception in thread "main" com.atomikos.icatch.SysException: Error in init: The specified log seems to be in use already: xa_tx in ./logs/. Make sure that no other instance is running, or kill any pending process if needed.
	at com.atomikos.icatch.provider.imp.AssemblerImp.createRepository(AssemblerImp.java:200)
	at com.atomikos.icatch.provider.imp.AssemblerImp.assembleTransactionService(AssemblerImp.java:170)
	at com.atomikos.icatch.config.Configuration.assembleSystemComponents(Configuration.java:424)
	at com.atomikos.icatch.config.Configuration.init(Configuration.java:390)
	at com.atomikos.icatch.config.UserTransactionServiceImp.initialize(UserTransactionServiceImp.java:100)
	at com.atomikos.icatch.config.UserTransactionServiceImp.init(UserTransactionServiceImp.java:189)
	at org.apache.shardingsphere.transaction.xa.atomikos.manager.AtomikosTransactionManagerProvider.init(AtomikosTransactionManagerProvider.java:46)
	at org.apache.shardingsphere.transaction.xa.XAShardingSphereTransactionManager.init(XAShardingSphereTransactionManager.java:55)
	at org.apache.shardingsphere.transaction.ShardingSphereTransactionManagerEngine.lambda$init$0(ShardingSphereTransactionManagerEngine.java:66)
	at java.util.Map.forEach(Map.java:630)
	at org.apache.shardingsphere.transaction.ShardingSphereTransactionManagerEngine.init(ShardingSphereTransactionManagerEngine.java:66)
	at org.apache.shardingsphere.transaction.rule.TransactionRule.createTransactionManagerEngine(TransactionRule.java:75)
	at org.apache.shardingsphere.transaction.rule.TransactionRule.createTransactionManagerEngines(TransactionRule.java:67)
	at org.apache.shardingsphere.transaction.rule.TransactionRule.<init>(TransactionRule.java:61)
	at org.apache.shardingsphere.transaction.rule.builder.TransactionRuleBuilder.build(TransactionRuleBuilder.java:36)
	at org.apache.shardingsphere.transaction.rule.builder.TransactionRuleBuilder.build(TransactionRuleBuilder.java:32)
	at org.apache.shardingsphere.infra.rule.builder.global.GlobalRulesBuilder.buildRules(GlobalRulesBuilder.java:53)
	at org.apache.shardingsphere.mode.manager.cluster.ClusterContextManagerBuilder.buildMetaDataContexts(ClusterContextManagerBuilder.java:91)
	at org.apache.shardingsphere.mode.manager.cluster.ClusterContextManagerBuilder.build(ClusterContextManagerBuilder.java:69)
	at org.apache.shardingsphere.proxy.initializer.BootstrapInitializer.createContextManager(BootstrapInitializer.java:66)
	at org.apache.shardingsphere.proxy.initializer.BootstrapInitializer.init(BootstrapInitializer.java:55)
	at org.apache.shardingsphere.proxy.Bootstrap.main(Bootstrap.java:50)
Caused by: com.atomikos.recovery.LogException: The specified log seems to be in use already: xa_tx in ./logs/. Make sure that no other instance is running, or kill any pending process if needed.
	at com.atomikos.persistence.imp.LogFileLock.acquireLock(LogFileLock.java:60)
	at com.atomikos.recovery.fs.FileSystemRepository.init(FileSystemRepository.java:53)
	at com.atomikos.icatch.provider.imp.AssemblerImp.createCoordinatorLogEntryRepository(AssemblerImp.java:248)
	at com.atomikos.icatch.provider.imp.AssemblerImp.createRepository(AssemblerImp.java:198)
	... 21 more

Example codes for reproduce this issue (such as a github link).

The text was updated successfully, but these errors were encountered:

jingshanglu · 2022-07-06T09:05:13Z

This is because two proxy are started on one machine, and the two proxy use the same file to record the transaction log, and different files can be used to record the transaction log.

sandynz · 2022-07-06T09:26:44Z

Hi @jingshanglu , the root reason is Atomikos XA transaction started when it's not configured, starting 2 proxy instances and print exception just prove Atomikos XA transaction has been started.

Is XA transaction must be started?
And could it just start LOCAL transaction? (Looks defaultType is LOCAL in TransactionRuleConfiguration)

jingshanglu · 2022-07-06T11:36:53Z

Hi @jingshanglu , the root reason is Atomikos XA transaction started when it's not configured, starting 2 proxy instances and print exception just prove Atomikos XA transaction has been started.

Is XA transaction must be started? And could it just start LOCAL transaction? (Looks defaultType is LOCAL in TransactionRuleConfiguration)

The XA transaction is not necessary. Currently, the specific implementation of TM is loaded through SPI. If there is an implementation of xa, the TM will be initialized unless the specific implementation of xa is removed. Any suggestions?

sandynz · 2022-07-06T12:50:22Z

The XA transaction is not necessary. Currently, the specific implementation of TM is loaded through SPI. If there is an implementation of xa, the TM will be initialized unless the specific implementation of xa is removed. Any suggestions?

If !TRANSACTION is not configured in server.yaml:

Should TransactionRule be initialized?
If TransactionRule is initialized, what's the defaultType of transaction (TransactionType), LOCAL, XA or BASE?

jingshanglu · 2022-07-07T02:46:26Z

The XA transaction is not necessary. Currently, the specific implementation of TM is loaded through SPI. If there is an implementation of xa, the TM will be initialized unless the specific implementation of xa is removed. Any suggestions?

If !TRANSACTION is not configured in server.yaml:

Should TransactionRule be initialized?

If TransactionRule is initialized, what's the defaultType of transaction (TransactionType), LOCAL, XA or BASE?
If !TRANSACTION is not configured in server.yaml:

TransactionRule should be initialized, because ss should provide the default transaction function
LOCAL， Atomikos for XA

sandynz · 2022-07-07T06:05:50Z

* TransactionRule should be initialized, because ss should provide the default transaction function

* LOCAL, Atomikos for XA

So could the default transaction function be LOCAL if !TRANSACTION is not configured?

XA is not necessary sometimes.

If we want to support XA even it's not configured, could we initialize XA implementation on demand?

miaopass-future · 2022-09-25T07:19:35Z

Hi, has this issue been resolved? I seem to have this problem too。The XA transaction does not seem to be opened, the LOCAL transaction is used

sandynz · 2022-09-28T06:46:32Z

Hi, has this issue been resolved? I seem to have this problem too。The XA transaction does not seem to be opened, the LOCAL transaction is used

Yes, it's not updated. I just checked it.

Example server.yaml:

#  - !TRANSACTION
#    defaultType: XA
#    providerType: Atomikos

proxy log:

[INFO ] 2022-09-28 14:44:12.542 [main-EventThread] o.a.c.framework.imps.EnsembleTracker - New config event received: {}
Thanks for using Atomikos! This installation is not registered yet. 
REGISTER FOR FREE at http://www.atomikos.com/Main/RegisterYourDownload and receive:
- tips & advice 
- working demos 
- access to the full documentation 
- special exclusive bonus offers not available to others 
- everything you need to get the most out of using Atomikos!

FlyingZC · 2022-11-08T04:16:19Z

@natehuangting

natehuangting · 2022-11-08T04:18:21Z

I will implement this function, other transaction types will not be loaded by default, if you need to load other transaction types, please configure in loadTypes

sandynz · 2023-05-17T03:11:57Z

Close it, it's fixed by #25696

jingshanglu added type: question feature: transaction labels Jul 6, 2022

linghengqian mentioned this issue Oct 10, 2022

How to execute RDL without use any existing database? #21442

Closed

This was referenced May 15, 2023

[New Feature] Optimize transaction manager creation logic #25674

Closed

Remove TransactionTypeHolder(#25674) #25696

Merged

sandynz closed this as completed May 17, 2023

sandynz added this to the 5.4.0 milestone May 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Atomikos XA transaction started when it is not configured in server.yaml #18894

Atomikos XA transaction started when it is not configured in server.yaml #18894

sandynz commented Jul 6, 2022

jingshanglu commented Jul 6, 2022

sandynz commented Jul 6, 2022 •

edited

Loading

jingshanglu commented Jul 6, 2022

sandynz commented Jul 6, 2022

jingshanglu commented Jul 7, 2022

sandynz commented Jul 7, 2022

miaopass-future commented Sep 25, 2022

sandynz commented Sep 28, 2022

FlyingZC commented Nov 8, 2022

natehuangting commented Nov 8, 2022

sandynz commented May 17, 2023 •

edited

Loading

Atomikos XA transaction started when it is not configured in server.yaml #18894

Atomikos XA transaction started when it is not configured in server.yaml #18894

Comments

sandynz commented Jul 6, 2022

Bug Report

Which version of ShardingSphere did you use?

Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?

Expected behavior

Actual behavior

Reason analyze (If you can)

Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.

Example codes for reproduce this issue (such as a github link).

jingshanglu commented Jul 6, 2022

sandynz commented Jul 6, 2022 • edited Loading

jingshanglu commented Jul 6, 2022

sandynz commented Jul 6, 2022

jingshanglu commented Jul 7, 2022

sandynz commented Jul 7, 2022

miaopass-future commented Sep 25, 2022

sandynz commented Sep 28, 2022

FlyingZC commented Nov 8, 2022

natehuangting commented Nov 8, 2022

sandynz commented May 17, 2023 • edited Loading

sandynz commented Jul 6, 2022 •

edited

Loading

sandynz commented May 17, 2023 •

edited

Loading