diff --git a/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingExecuteEngine.java b/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingExecuteEngine.java index 3e2f8ad1a53f5..b229acac25464 100644 --- a/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingExecuteEngine.java +++ b/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingExecuteEngine.java @@ -54,7 +54,7 @@ public ShardingExecuteEngine(final int executorSize) { } /** - * Execute all callbacks. + * Execute. * * @param inputs input values * @param callback sharding execute callback @@ -68,7 +68,7 @@ public List execute(final Collection inputs, final ShardingExecuteC } /** - * Execute all callbacks. + * Execute. * * @param inputs input values * @param firstCallback first sharding execute callback @@ -120,7 +120,7 @@ private List getResults(final O firstResult, final Collection List groupExecute(final Collection> inp } /** - * execute all callbacks for group. + * Execute for group. * * @param inputGroups input groups * @param callback sharding execute callback diff --git a/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingGroupExecuteCallback.java b/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingGroupExecuteCallback.java index 861fac925cde8..5004ef1a4cee0 100644 --- a/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingGroupExecuteCallback.java +++ b/sharding-core/src/main/java/io/shardingsphere/core/executor/ShardingGroupExecuteCallback.java @@ -25,8 +25,8 @@ * * @author zhangliang * - * @param type of input value - * @param type of output value + * @param type of inputs value + * @param type of outputs value */ public interface ShardingGroupExecuteCallback { diff --git a/sharding-core/src/main/java/io/shardingsphere/core/executor/sql/execute/SQLExecuteTemplate.java b/sharding-core/src/main/java/io/shardingsphere/core/executor/sql/execute/SQLExecuteTemplate.java index c1f10a14c8a8a..b941e9e08a4f6 100644 --- a/sharding-core/src/main/java/io/shardingsphere/core/executor/sql/execute/SQLExecuteTemplate.java +++ b/sharding-core/src/main/java/io/shardingsphere/core/executor/sql/execute/SQLExecuteTemplate.java @@ -47,13 +47,13 @@ public final class SQLExecuteTemplate { * Execute. * * @param executeUnits execute units - * @param executeCallback execute callback + * @param callback execute callback * @param class type of return value * @return execute result * @throws SQLException SQL exception */ - public List execute(final Collection executeUnits, final SQLExecuteCallback executeCallback) throws SQLException { - return execute(executeUnits, null, executeCallback); + public List execute(final Collection executeUnits, final SQLExecuteCallback callback) throws SQLException { + return execute(executeUnits, null, callback); } /** @@ -61,18 +61,18 @@ public List execute(final Collection exec * * @param executeUnits execute units * @param firstExecuteCallback first execute callback - * @param executeCallback execute callback + * @param callback execute callback * @param class type of return value * @return execute result * @throws SQLException SQL exception */ @SuppressWarnings("unchecked") public List execute(final Collection executeUnits, - final SQLExecuteCallback firstExecuteCallback, final SQLExecuteCallback executeCallback) throws SQLException { + final SQLExecuteCallback firstExecuteCallback, final SQLExecuteCallback callback) throws SQLException { OverallExecutionEvent event = new OverallExecutionEvent(executeUnits.size() > 1); ShardingEventBusInstance.getInstance().post(event); try { - List result = executeEngine.execute((Collection) executeUnits, firstExecuteCallback, executeCallback); + List result = executeEngine.execute((Collection) executeUnits, firstExecuteCallback, callback); event.setExecuteSuccess(); return result; // CHECKSTYLE:OFF