Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Config] Rename source_table_name /result_table_name #8062

Closed
3 tasks done
hailin0 opened this issue Nov 15, 2024 · 1 comment · Fixed by #8072
Closed
3 tasks done

[Feature][Config] Rename source_table_name /result_table_name #8062

hailin0 opened this issue Nov 15, 2024 · 1 comment · Fixed by #8072
Assignees
@hailin0
Labels
discuss

Comments

@hailin0
Copy link
Member

hailin0 commented Nov 15, 2024

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

I think result_table_name is ambiguous with source_table_name and needs to be redefined to a suitable name. Do you have any suggestions?

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@hailin0 hailin0 self-assigned this Nov 15, 2024
@hailin0
Copy link
Member Author

hailin0 commented Nov 15, 2024 •
edited
Loading

source_table_name -> plugin_input
result_table_name -> plugin_output

or

source_table_name -> plugin_input_identifier
result_table_name -> plugin_output_identifier

@hailin0 hailin0 changed the title [Feature][Config] Rename config key [Feature][Config] Rename source_table_name /result_table_name Nov 16, 2024
@hailin0 hailin0 mentioned this issue Nov 16, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hailin0 hailin0

Labels
discuss
Projects
None yet
Milestone
No milestone
2 participants
@hailin0 @liunaijie