diff --git a/auth/src/main/java/org/apache/rocketmq/auth/authentication/factory/AuthenticationFactory.java b/auth/src/main/java/org/apache/rocketmq/auth/authentication/factory/AuthenticationFactory.java index 3d1f7fdb04e4..3ba82add5ab9 100644 --- a/auth/src/main/java/org/apache/rocketmq/auth/authentication/factory/AuthenticationFactory.java +++ b/auth/src/main/java/org/apache/rocketmq/auth/authentication/factory/AuthenticationFactory.java @@ -142,7 +142,9 @@ private static V computeIfAbsent(String key, Function f } if (result == null) { result = function.apply(key); - INSTANCE_MAP.put(key, result); + if (result != null) { + INSTANCE_MAP.put(key, result); + } } } } diff --git a/auth/src/main/java/org/apache/rocketmq/auth/authorization/factory/AuthorizationFactory.java b/auth/src/main/java/org/apache/rocketmq/auth/authorization/factory/AuthorizationFactory.java index 815a68b0f36e..f87a5304cb74 100644 --- a/auth/src/main/java/org/apache/rocketmq/auth/authorization/factory/AuthorizationFactory.java +++ b/auth/src/main/java/org/apache/rocketmq/auth/authorization/factory/AuthorizationFactory.java @@ -19,9 +19,9 @@ import com.google.protobuf.GeneratedMessageV3; import io.grpc.Metadata; import io.netty.channel.ChannelHandlerContext; +import java.util.HashMap; import java.util.List; -import java.util.concurrent.ConcurrentHashMap; -import java.util.concurrent.ConcurrentMap; +import java.util.Map; import java.util.function.Function; import java.util.function.Supplier; import org.apache.commons.lang3.StringUtils; @@ -39,7 +39,7 @@ public class AuthorizationFactory { - private static final ConcurrentMap INSTANCE_MAP = new ConcurrentHashMap<>(); + private static final Map INSTANCE_MAP = new HashMap<>(); private static final String PROVIDER_PREFIX = "PROVIDER_"; private static final String METADATA_PROVIDER_PREFIX = "METADATA_PROVIDER_"; private static final String EVALUATOR_PREFIX = "EVALUATOR_"; @@ -145,7 +145,9 @@ private static V computeIfAbsent(String key, Function f } if (result == null) { result = function.apply(key); - INSTANCE_MAP.put(key, result); + if (result != null) { + INSTANCE_MAP.put(key, result); + } } } }