Adding a new config skipSegmentPreprocess in table IndexingConfig #14982
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
added
the
Configuration
Jackie-Jiang
reviewed
Feb 4, 2025
...al/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
allow-skip-segment-preprocess
branch
2 times, most recently
from
27ee253 to
ac474c9
Compare
xiangfu0
force-pushed
the
allow-skip-segment-preprocess
branch
from
ac474c9 to
45dbdfb
Compare
Jackie-Jiang
approved these changes
Feb 4, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14982 +/- ##
============================================
+ Coverage 61.75% 63.70% +1.94%
- Complexity 207 1480 +1273
============================================
Files 2436 2713 +277
Lines 133233 152171 +18938
Branches 20636 23526 +2890
============================================
+ Hits 82274 96935 +14661
- Misses 44911 47943 +3032
- Partials 6048 7293 +1245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
changed the title
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config:
skipSegmentPreprocessinTableConfig->IndexingConfigallows the table to skip preprocess during server startup or reload.