Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in pom files, set name to have 'Apache Pekko ...' #1006

Closed
Tracked by #1052
pjfanning opened this issue Jan 21, 2024 · 6 comments
Closed
Tracked by #1052

in pom files, set name to have 'Apache Pekko ...' #1006

pjfanning opened this issue Jan 21, 2024 · 6 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@pjfanning
Copy link
Contributor

Our poms are generated by sbt and the name in the pom closely matches the artifactId

https://repo1.maven.org/maven2/org/apache/pekko/pekko-stream_3/1.0.2/pekko-stream_3-1.0.2.pom

See name=pekko-stream, artifactId=pekko-stream_3

We only set the name in sbt but if we change it, it affects the artifactId. We need to keep the artifactId as is.

But for this pom, we should have name=Apache Pekko Stream (or something like that - Apache Pekko bit is the key).

Requirement comes in https://lists.apache.org/thread/wmp9g94fo2yb4tsg238467d6hx72dbml

Liable to become something that can block our releases and graduation to be a TLP.

I have tried a few sbt changes but nothing that gets the results that we need.

@pjfanning pjfanning added the help wanted Extra attention is needed label Jan 21, 2024
@pjfanning pjfanning added this to the 1.0.x milestone Jan 21, 2024
@He-Pin
Copy link
Member

He-Pin commented Jan 21, 2024

Do you mean the <name>pekko-stream</name> should be <name>apache-pekko-stream</name>

@pjfanning
Copy link
Contributor Author

artifactId must stay as pekko-stream_3 but the name should be Apache Pekko Stream

@laglangyue
Copy link
Contributor

laglangyue commented Jan 21, 2024

I just gave it a try for demo project, it's ok, I am preparing a PR for pekko

    publishM2Configuration := publishM2Configuration.value
      .withOverwrite(true)
      .withPublishMavenStyle(true),
      // rename module
    makePomConfiguration := makePomConfiguration.value.withModuleInfo(
      makePomConfiguration.value.moduleInfo.get.withNameFormal("apache")
    )

@mdedetrich
Copy link
Contributor

@laglangyue I would hold off a bit as we are trying to verify if we actually need to do this, @pjfanning Has more details.

If we do end up needing to do this we will also likely end up creating an abstraction in https://github.com/pjfanning/sbt-pekko-build

@laglangyue
Copy link
Contributor

@laglangyue I would hold off a bit as we are trying to verify if we actually need to do this, @pjfanning Has more details.

If we do end up needing to do this we will also likely end up creating an abstraction in https://github.com/pjfanning/sbt-pekko-build

okey, waitting for this

@pjfanning
Copy link
Contributor Author

changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants