From 99f9b15f3193bad3524a249c0e06cd0313c83d5e Mon Sep 17 00:00:00 2001 From: Oscar Torreno Date: Thu, 25 Jul 2024 23:17:56 +0200 Subject: [PATCH] Fix supportVectoredIO for bad hadoop version string There are cases where the hadoop version info may not be respecting the semantic versioning. It is the case for the hadoop version provided in some of the AWS managed services. This causes a ExceptionInInitializerError while trying to instantiate and ORC file reader. Fixing this by defaulting to non vectored IO in case the semantic versioning is not respected --- .../java/org/apache/orc/impl/HadoopShims.java | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/java/shims/src/java/org/apache/orc/impl/HadoopShims.java b/java/shims/src/java/org/apache/orc/impl/HadoopShims.java index 2ae0364f25e..d8e32296547 100644 --- a/java/shims/src/java/org/apache/orc/impl/HadoopShims.java +++ b/java/shims/src/java/org/apache/orc/impl/HadoopShims.java @@ -22,6 +22,8 @@ import org.apache.hadoop.fs.FSDataInputStream; import org.apache.hadoop.util.VersionInfo; import org.apache.orc.EncryptionAlgorithm; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import java.io.Closeable; import java.io.IOException; @@ -133,12 +135,18 @@ ByteBuffer readBuffer(int maxLength, boolean endVariableLengthBlock(OutputStream output) throws IOException; default boolean supportVectoredIO() { - // HADOOP-18103 is available since Apache Hadoop 3.3.5+ - String[] versionParts = VersionInfo.getVersion().split("[.]"); - int major = Integer.parseInt(versionParts[0]); - int minor = Integer.parseInt(versionParts[1]); - int patch = Integer.parseInt(versionParts[2]); - return major == 3 && (minor > 3 || (minor == 3 && patch > 4)); + try { + // HADOOP-18103 is available since Apache Hadoop 3.3.5+ + String[] versionParts = VersionInfo.getVersion().split("[.]"); + int major = Integer.parseInt(versionParts[0]); + int minor = Integer.parseInt(versionParts[1]); + int patch = Integer.parseInt(versionParts[2]); + return major == 3 && (minor > 3 || (minor == 3 && patch > 4)); + } catch (final NumberFormatException e) { + // There could be cases where we are not able to parse the version + // Here we are defaulting to the non vectoredIO if that is the case + return false; + } } /**