From af0712d35a8a62be9c56b86a1b97768b7c1afa88 Mon Sep 17 00:00:00 2001
From: Jorge Hermo <jorgehermogonzalez@gmail.com>
Date: Fri, 1 Nov 2024 12:57:22 +0100
Subject: [PATCH 1/2] chore: include object_store tests in ci

---
 .github/workflows/ci_integration_object_store.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/ci_integration_object_store.yml b/.github/workflows/ci_integration_object_store.yml
index 824186aef1de..bedd48aa3e99 100644
--- a/.github/workflows/ci_integration_object_store.yml
+++ b/.github/workflows/ci_integration_object_store.yml
@@ -45,3 +45,7 @@ jobs:
       - name: Cargo clippy
         working-directory: integrations/object_store
         run: cargo clippy --all-targets --all-features -- -D warnings
+
+      - name: Cargo test
+        working-directory: integrations/object_store
+        run: cargo test

From 4f0ba3eda2b9ba2401fc304d89adbbbe0c0717d7 Mon Sep 17 00:00:00 2001
From: Jorge Hermo <jorgehermogonzalez@gmail.com>
Date: Fri, 1 Nov 2024 14:19:14 +0100
Subject: [PATCH 2/2] test: fix broken doctest

---
 integrations/object_store/src/lib.rs   | 15 +++++----------
 integrations/object_store/src/store.rs | 15 +++++----------
 2 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/integrations/object_store/src/lib.rs b/integrations/object_store/src/lib.rs
index 37b46d171bb2..2afe685eb89e 100644
--- a/integrations/object_store/src/lib.rs
+++ b/integrations/object_store/src/lib.rs
@@ -31,16 +31,11 @@
 //!
 //! #[tokio::main]
 //! async fn main() {
-//!     let builder = S3::from_map(
-//!         vec![
-//!             ("access_key".to_string(), "my_access_key".to_string()),
-//!             ("secret_key".to_string(), "my_secret_key".to_string()),
-//!             ("endpoint".to_string(), "my_endpoint".to_string()),
-//!             ("region".to_string(), "my_region".to_string()),
-//!         ]
-//!         .into_iter()
-//!         .collect(),
-//!     ).unwrap();
+//!    let builder = S3::default()
+//!     .access_key_id("my_access_key")
+//!     .secret_access_key("my_secret_key")
+//!     .endpoint("my_endpoint")
+//!     .region("my_region");
 //!
 //!     // Create a new operator
 //!     let operator = Operator::new(builder).unwrap().finish();
diff --git a/integrations/object_store/src/store.rs b/integrations/object_store/src/store.rs
index d7dc8193a108..1339f1bb78fe 100644
--- a/integrations/object_store/src/store.rs
+++ b/integrations/object_store/src/store.rs
@@ -62,16 +62,11 @@ use tokio::sync::{Mutex, Notify};
 ///
 /// #[tokio::main]
 /// async fn main() {
-///     let builder = S3::from_map(
-///         vec![
-///             ("access_key".to_string(), "my_access_key".to_string()),
-///             ("secret_key".to_string(), "my_secret_key".to_string()),
-///             ("endpoint".to_string(), "my_endpoint".to_string()),
-///             ("region".to_string(), "my_region".to_string()),
-///         ]
-///         .into_iter()
-///         .collect(),
-///     ).unwrap();
+///    let builder = S3::default()
+///     .access_key_id("my_access_key")
+///     .secret_access_key("my_secret_key")
+///     .endpoint("my_endpoint")
+///     .region("my_region");
 ///
 ///     // Create a new operator
 ///     let operator = Operator::new(builder).unwrap().finish();