Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature requests: Add undelete support #4321

Open
Xuanwo opened this issue Mar 5, 2024 · 4 comments
Open

feature requests: Add undelete support #4321

Xuanwo opened this issue Mar 5, 2024 · 4 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 5, 2024

Part of #2611

After we have object versioning, it's possible for us add API like undelete which can restore a file from deleted states.

There are several possibilities:

  • Add API like undelete / restore which focus on restore deleted files from existing versions.
  • Add API like promote which focus on promote existing version as current version (this covers restore, but harder for users to understand what it does)
  • Extend copy instead of adding new API.
  • Welcome new designs

References

How to restore deleted files in cloud storage?

  • S3: delete delete_marker for an object, delete_marker should be fetched via list_objects_version
  • Gcs: In Cloud Storage, restoring a noncurrent object version means making a copy of it
  • Azblob: To restore the current version, first restore all soft-deleted versions, and then use the Copy Blob operation to copy a previous version to a new current version.
@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 5, 2024

Maybe also related to #4032

@hoslo
Copy link
Contributor

hoslo commented Mar 8, 2024

@Xuanwo I'm interest in this, how we should start?

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 8, 2024

@Xuanwo I'm interest in this, how we should start?

We don't yet have a clear implementation strategy. Please conduct some research and initially propose your design. Then, we can proceed to the RFC stage.

@hoslo
Copy link
Contributor

hoslo commented Mar 18, 2024

@Xuanwo I'm interest in this, how we should start?

We don't yet have a clear implementation strategy. Please conduct some research and initially propose your design. Then, we can proceed to the RFC stage.

I'm not sure what to propose RFC, but i think.

  • In the file system that supports trash, we can support restore (in the current yandex disk api we delete files directly by default, maybe we need to change the default delete behavior to trash).
  • In the supported version of the file system, We can support restore_with_version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants