Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for Java binding catching up behaviors #3169

Closed
6 of 7 tasks
tisonkun opened this issue Sep 24, 2023 · 8 comments
Closed
6 of 7 tasks

Tracking issue for Java binding catching up behaviors #3169

tisonkun opened this issue Sep 24, 2023 · 8 comments

Comments

@tisonkun
Copy link
Member

tisonkun commented Sep 24, 2023

Now that we have a behavior test framework for Java binding, it's possible to catch up features driven by the behavior tests compared with core's behavior tests.

For example:

@tisonkun
Copy link
Member Author

@G-XD you may extend the list above if you have time to sort out all the behavior our Java binding should support.

@G-XD
Copy link
Contributor

G-XD commented Sep 26, 2023

@G-XD you may extend the list above if you have time to sort out all the behavior our Java binding should support.

Ok, I'll continue to refine the behavior tests of the java binding in my free time.

@tisonkun
Copy link
Member Author

@G-XD since you're a committer now, you should be able to directly edit this issue :D

@G-XD
Copy link
Contributor

G-XD commented Oct 12, 2023

Hi @tisonkun, @Xuanwo , I'm planning to support list operations on the java binding, should I patch the Metadata related functionality first?

@tisonkun
Copy link
Member Author

should I patch the Metadata related

This can be reasonable. The last time I thought of list I found that we should wrap its return value (Entry) into a new NativeObject. Or we can make Metadata a POJO (as you did for OperatorInfo/Capability) and so does Entry.

@G-XD
Copy link
Contributor

G-XD commented Nov 7, 2023

Currently only the ipfs service can trigger the list_only behaviors test, but ci is disabled for ipfs, so do I still need to add the list_only test to the java binding? cc @tisonkun @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Nov 7, 2023

Currently only the ipfs service can trigger the list_only behaviors test, but ci is disabled for ipfs, so do I still need to add the list_only test to the java binding?

Let's ignore it until we have real use cases.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

Most work has been done, let's close!

@Xuanwo Xuanwo closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants