Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Divergence of implementation between Windows and non-Windows #18281

Closed
leezu opened this issue May 11, 2020 · 3 comments
Closed

Divergence of implementation between Windows and non-Windows #18281

leezu opened this issue May 11, 2020 · 3 comments

Comments

@leezu
Copy link
Contributor

leezu commented May 11, 2020

https://github.com/apache/incubator-mxnet/blob/f00b9ab5b4410a91a8f6581da696a92f85fbccf6/src/operator/numpy/np_elemwise_broadcast_op.cu#L32-L41

Shouldn't be needed anymore as 64-bit toolchain is now required on Windows? (Added due to compiler OOM errors when 32-bit toolchain was in use)

@leezu
Copy link
Contributor Author

leezu commented May 13, 2020

In GluonNLP Windows CI, tests fail on Windows with errors like

2020-05-13T12:06:33.5890094Z >           raise get_last_ffi_error()
2020-05-13T12:06:33.5890252Z E           mxnet.base.MXNetError: Traceback (most recent call last):
2020-05-13T12:06:33.5890363Z E             File "c:\jenkins\workspace\mxnet\mxnet\src\imperative\./imperative_utils.h", line 251
2020-05-13T12:06:33.5893446Z E           MXNetError: Check failed: outputs[i]->dtype() == out_types[i] (0 vs. 1) : 0-th output has invalid dtype. Expecting 1 got 0 in operator _npi_uniform

https://github.com/sxjscience/gluon-nlp/commit/9623f62ad0daeaf6d8b251743ea7c1d27c08e1e0/checks/670163041/logs

This may be due to the diverging implementation described above, or there are more issues. @zhreshold @yzhliu

@yzhliu yzhliu added the WIP label Jun 9, 2020
@yzhliu
Copy link
Member

yzhliu commented Jun 9, 2020

@BenjaminCHEN2016 is helping.

@yzhliu
Copy link
Member

yzhliu commented Jun 11, 2020

closed by #18523

@yzhliu yzhliu closed this as completed Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants