[SIP-6] removed get_data for BigNumber #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conglei
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5861 +/- ##
===========================================
- Coverage 77.99% 63.66% -14.33%
===========================================
Files 46 376 +330
Lines 9312 23337 +14025
Branches 0 2612 +2612
===========================================
+ Hits 7263 14858 +7595
- Misses 2049 8466 +6417
- Partials 0 13 +13
Continue to review full report at Codecov.
|
conglei
force-pushed
the
conglei_big_number_sip6
branch
from
509b140 to
c63a52e
Compare
kristw
reviewed
Sep 12, 2018
| @@ -0,0 +1,5 @@ | |||
| import adapter from './adaptor'; | |||
| @@ -26,7 +23,7 @@ const PROPORTION = { | |||
| TRENDLINE: 0.3, | |||
| }; | |||
|
|
|||
| function renderTooltipFactory(formatValue) { | |||
| export function renderTooltipFactory(formatValue) { | |||
There was a problem hiding this comment.
This was used only in this file. Not sure it is useful to export now. (ok to expert if there are other places using or unit test)
There was a problem hiding this comment.
Actually it is also used in adaptor for the prop renderTooltip. That is why I exported it :)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* removed get_data for BigNumber * removed duplicated condition * fixed typo
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to move
get_datalogic forBigNumberandBigNumberTotal into frontend code.#5692
@kristw @williaster @mistercrunch