Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[table editor] better table header for Metrics tab #5725

Merged
merged 1 commit into from
Aug 28, 2018
Merged

[table editor] better table header for Metrics tab #5725

merged 1 commit into from
Aug 28, 2018

Conversation

mistercrunch
Copy link
Member

screen shot 2018-08-24 at 6 14 34 pm

@codecov-io
Copy link

codecov-io commented Aug 25, 2018 •
edited
Loading

Codecov Report

Merging #5725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5725   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       22995    22995           
  Branches     2559     2559           
=======================================
  Hits        14575    14575           
  Misses       8405     8405           
  Partials       15       15
Impacted Files Coverage Δ
...uperset/assets/src/datasource/DatasourceEditor.jsx 72.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ae215...e964d83. Read the comment docs.

betodealmeida
betodealmeida approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@betodealmeida betodealmeida merged commit 4ae08c2 into apache:master Aug 28, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@betodealmeida
Merge pull request apache#5725 from mistercrunch/label_verbose_name
cfab3c9 
[table editor] better table header for Metrics tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @codecov-io @betodealmeida