Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor World Map #5719

Merged
merged 2 commits into from
Aug 29, 2018
Merged

[SIP-5] Refactor World Map #5719

merged 2 commits into from
Aug 29, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 24, 2018

  • Extract slice and formData according to [SIP-5]

@williaster @conglei

@kristw kristw changed the title extract slice and formData [SIP-5] Refactor World Map Aug 24, 2018
@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #5719 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5719      +/-   ##
==========================================
- Coverage   63.43%   63.41%   -0.02%     
==========================================
  Files         361      361              
  Lines       22977    22984       +7     
  Branches     2558     2558              
==========================================
  Hits        14575    14575              
- Misses       8387     8394       +7     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/visualizations/world_map.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14930bb...9615714. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 👍

@williaster williaster merged commit 00cc6e9 into apache:master Aug 29, 2018
@kristw kristw deleted the kristw-worldmap branch August 29, 2018 22:26
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 5, 2018
* extract slice and formData

* update proptypes of data

(cherry picked from commit 00cc6e9)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* extract slice and formData

* update proptypes of data
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* extract slice and formData

* update proptypes of data
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants