Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow 7 tabs, remove 'slice_' prefix in logs #5411

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

williaster
Copy link
Contributor

Title says it all :)

@graceguo-supercat @john-bodley

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #5411 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5411   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files         373      373           
  Lines       23709    23709           
  Branches     2750     2750           
=======================================
  Hits        14513    14513           
  Misses       9181     9181           
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/chart/Chart.jsx 66.1% <ø> (ø) ⬆️
superset/assets/src/chart/chartAction.js 46.77% <ø> (ø) ⬆️
...sets/src/dashboard/deprecated/chart/chartAction.js 0% <ø> (ø) ⬆️
...s/src/dashboard/components/gridComponents/Tabs.jsx 80.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4e6c7...6c396a1. Read the comment docs.

@williaster williaster merged commit 7670e0c into apache:master Jul 17, 2018
@williaster williaster deleted the chris--tab-limits-and-logging branch July 17, 2018 20:25
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jul 19, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
williaster added a commit to airbnb/superset-fork that referenced this pull request Aug 6, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@ayssi
Copy link

ayssi commented Nov 16, 2018

Please, I've some problems to increase the number of tabs (from 7 to 13 for Ex) in dashoboad V2. I work with superset 0.28.1
Thanks

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants