Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump FAB and a bunch of JS libs #5122

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Bump FAB and a bunch of JS libs #5122

merged 1 commit into from
Jun 11, 2018

Conversation

mistercrunch
Copy link
Member

No description provided.

@xrmx xrmx mentioned this pull request Jun 2, 2018
Closed
@betodealmeida
Copy link
Member

This is failing because of the migration script — same error as described in #5088.

@codecov-io
Copy link

Codecov Report

Merging #5122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5122   +/-   ##
=======================================
  Coverage   77.47%   77.47%           
=======================================
  Files          44       44           
  Lines        8741     8741           
=======================================
  Hits         6772     6772           
  Misses       1969     1969

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e1256...193a09b. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Jun 10, 2018

🚢

@mistercrunch mistercrunch merged commit a3477ab into apache:master Jun 11, 2018
@mistercrunch mistercrunch deleted the pin_fab branch June 11, 2018 04:43
williaster
williaster reviewed Jun 11, 2018
View reviewed changes
superset/assets/package.json
@@ -150,13 +152,15 @@
"react-addons-test-utils": "^15.6.2",
"react-test-renderer": "^15.6.2",
"redux-mock-store": "^1.2.3",
"sinon": "^4.0.0",
"style-loader": "^0.18.2",
"//": "known minor issues in >5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistercrunch what are these entries with double backslashes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this as a suggested way to squeeze comments into JSON:
https://stackoverflow.com/questions/14221579/how-do-i-add-comments-to-package-json-for-npm-install

This works with yarn but not the current version npm. I'm pretty sure npm used to allow this but not 100%. On Slack I mentioned to @GabeLoins that this may be a good way to force people to use yarn as a result, since we now use yarn.lock

timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@mistercrunch @timifasubaa
Pin FAB and bump a bunch of JS libs (apache#5122)
a5c305b
@octaviancorlade octaviancorlade mentioned this pull request Jul 27, 2018
Closed
3 tasks
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Pin FAB and bump a bunch of JS libs (apache#5122)
656307f
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistercrunch @betodealmeida @codecov-io @hughhhh @williaster