Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '.1%' to number format options #4720

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

mistercrunch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #4720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4720   +/-   ##
=======================================
  Coverage   71.88%   71.88%           
=======================================
  Files         204      204           
  Lines       15329    15329           
  Branches     1177     1177           
=======================================
  Hits        11020    11020           
  Misses       4306     4306           
  Partials        3        3
Impacted Files Coverage Δ
...set/assets/javascripts/explore/stores/controls.jsx 39.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49a0e7...4b6e970. Read the comment docs.

@williaster
Copy link
Contributor

this should be the (smart) default everywhere IMO! lots of charts have way too many decimal places. almost wish we could apply a db migration for it but that'd be harder.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

@mistercrunch mistercrunch merged commit 221b35f into apache:master Apr 2, 2018
@mistercrunch mistercrunch deleted the point_one_percent branch April 2, 2018 04:13
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants