-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): graph support multiple edges, for #6811 #12590
Conversation
Thanks for your contribution! |
Chinese comments removed~~ |
Great feature 👍 |
Hey , I really need this pr when will it be merged? |
Someone please review this :-) we also need this |
This is also my urgent need pr... |
@100pah Thanks for your suggestions and code review, this is a great help! Thanks! |
@wf123537200 |
@100pah 3q for the review and the suggest, i fixed it. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
@wf123537200 Thanks for your great work! |
👍 Documentation about this new feature is waiting to be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this PR has been merged, there may be some parts could be optimized.
@plainheart 3q for fix this |
i will add to documentation ASAP. |
I found that in some cases, toggle legend will make multiple lines into single one.(overlapping) Check it out in this demo: https://gallery.echartsjs.com/editor.html?c=xNQsu5DekH&v=2 Then I figured that I changed two lines, and it worked. // var source = [n1.id, n1.dataIndex].join('.');
var source = n1.id;
// var target = [n2.id, n2.dataIndex].join('.');
var target = n2.id; I am wondering why |
the
type=graph
support multiple edges between two nodesThis pull request is in the type of:
What does this PR do?
the
type=graph
support multiple edges between two nodesFixed issues
#6811
Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
series > autoCurveness
Related test cases or examples to use the new APIs
graph-mulitple-edges.html
Others
Merging options
Other information