-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 12109 #12418
Fix 12109 #12418
Conversation
This reverts commit 3c781f5.
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. The basic idea is all right but some modification is required.
This reverts commit 66f5c04.
|
Did you set correct user.name and user.email? |
Sorry, not quite sure of the problem. |
I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit |
I got your point. Should I change account and commit again? |
That won't be necessary, Squash all commits then merge can do the job. I think. |
Thanks, I'll make a try. |
Or you can force push. |
fix: 12109, add test case Revert "fix: 12109 add test case" This reverts commit 66f5c04. fix: 12109, add case in issue
Do you know where to see if I had done right? |
@susiwen8 Clear, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some test cases don't have expected result.
Please compare with bar under grid: (change the data and min max)
option = {
xAxis: {
data: ['A', 'B', 'C']
},
yAxis: {
min: 1,
max: 6
},
series: [{
name: '模拟数据',
type: 'bar',
stack: 'a',
data: [2, 2, 2]
}, {
stack: 'a',
type: 'bar',
data: [2, 2, 2]
}, {
stack: 'a',
type: 'bar',
data: [2, 2, 2]
}]
};
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
correct bar polar rendering negative values
Fixed issues
#12109
Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information