-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(axis): Add minorTick and minorSplitLine #11705
Conversation
src/component/axis/AxisBuilder.js
Outdated
fixMinMaxLabelShow(axisModel, labelEls, tickEls); | ||
fixMinMaxLabelShow(axisModel, labelEls, ticksEls); | ||
|
||
buildMinorAxisTicks(this, axisModel, opt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildAxisMajorTicks
buildMinorAxisTicks
.
maybe buildAxisMajorTicks
buildAxisMinorTicks
.
or buildMajorAxisTicks
buildMinorAxisTicks
.
is better.
But it's not important.
@@ -85,6 +77,9 @@ var CartesianAxisView = AxisView.extend({ | |||
this._splitAreaColors = null; | |||
}, | |||
|
|||
_createSplitLines: function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
src/coord/Axis.js
Outdated
return []; | ||
} | ||
|
||
opt = opt || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opt
seams not be used.
fix(polar): fix axis line not display in polar caused by #11705
This feature has a bug when used in a dynamic timeseries plot: How can we correct this issue? |
I don't have the time to properly contribute right now as i'm completely swamped, but I've provided a fix for this bug in the comments of issue #18422 |
This is a pull request about adding
minorTicks
,minorSplitLines
to axes of carteisan2d and polar coordinate system. It not supportcategory
type axis.Usage:
The default option is in https://github.com/apache/incubator-echarts/compare/minor-ticks?expand=1#diff-af7ed0ab793833949acec7caafa8646eR180
Here is some shots.
With dataZoom.

All tests.
