Fix sankey frequent flashing with hovering on the node and edge #11306 #11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deqingli
commented
Nov 6, 2019
deqingli
commented
- Add an unfocusNodeAdjacency delay execution timer to delay execute the action.
- Add focus state make sure to execute the right action.
|
I think Like in the |
pissang
reviewed
Nov 8, 2019
src/chart/graph/GraphView.js
Outdated
| @@ -163,17 +164,15 @@ export default echarts.extendChartView({ | |||
|
|
|||
| if (itemModel.get('focusNodeAdjacency')) { | |||
| el.on('mouseover', el[FOCUS_ADJACENCY] = function () { | |||
| clearTimeout(this._unfocusDelayTimer); | |||
There was a problem hiding this comment.
Also needs to set this._unfocusDelayTimer to null here. And in the following code with clearTimeout
There was a problem hiding this comment.
Thank you, I have fixed it.
pissang
approved these changes
Nov 8, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.