fix(pie): label not show when animation is disabled. fix #12110 #12243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Hover style is not used if pie animation is set to be false.
Fixed issues
Details
Before: What was the problem?
Test
test/pie-animation.html
. Label is not shown when hover on the pie.After: How is it fixed in this PR?
labelLine.ignore
andlabelText.ignore
should be changed intohoverIgnore
, even if without animation.Note that a user may set
animation
to be true whilehoverAnimation
to be false for a pie chart to have the transition animation at initiation. So checking bothitemModel.get('hoverAnimation') && seriesModel.isAnimationEnabled()
in 9847233#diff-19529e7aaddb5ad8b1b45417c96c8e00R184 does not update the animation states for transition animation.Usage
Are there any API changes?
Related test cases or examples to use the new APIs
test/pie-animation.html
and a visual test about it.Others
Merging options
Other information