Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve:ProviderMethodModel add parameterClasses #3693

Merged
merged 1 commit into from
Mar 20, 2019
Merged

improve:ProviderMethodModel add parameterClasses #3693

merged 1 commit into from
Mar 20, 2019

Conversation

qinliujie
Copy link
Contributor

What is the purpose of the change

add more information for ProviderMethodModel

Brief changelog

ProviderMethodModel add parameterClasses and genericParameterTypes property

@codecov-io
Copy link

Codecov Report

Merging #3693 into 3.x-dev will decrease coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3693      +/-   ##
=============================================
- Coverage       63.8%   63.79%   -0.02%     
  Complexity        75       75              
=============================================
  Files            656      656              
  Lines          28449    28454       +5     
  Branches        4812     4812              
=============================================
- Hits           18152    18151       -1     
- Misses          8009     8020      +11     
+ Partials        2288     2283       -5
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/dubbo/rpc/model/ProviderModel.java 68.57% <0%> (-2.02%) 0 <0> (ø)
...rg/apache/dubbo/rpc/model/ProviderMethodModel.java 77.27% <50%> (-6.07%) 0 <0> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 70.73% <0%> (-14.64%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-2.21%) 0% <0%> (ø)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 68.13% <0%> (-2.2%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.15% <0%> (-1.35%) 0% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 65.25% <0%> (-0.85%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 74.16% <0%> (+1.66%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6272691...b0a327f. Read the comment docs.

@@ -74,6 +74,11 @@ public ProviderMethodModel getMethodModel(String methodName, String[] argTypes)
return null;
}

public List<ProviderMethodModel> getMethodModelList(String methodName) {
return methods.get(methodName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may return null value, are you expecting that? Typically when you want to return a List, user will expect an empty list rather than null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants