Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change customized stoppable check log level #3004

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

MarkGaox
Copy link
Contributor

@MarkGaox MarkGaox commented Feb 12, 2025

Issues

  • My PR addresses the following Helix issues and references them in the PR description:
    N/A

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This PR changes the log level to DEBUG so the stoppable end won't generate excessive logs when the customized stoppable check json response is massive.

Tests

  • The following tests are written for this issue:
    N/A

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@MarkGaox
Copy link
Contributor Author

The PR is approved by @xyuanlu and is ready to merge. The failed CI is an known issue #2967
Final commit message: Change customized stoppable check log level

@xyuanlu xyuanlu merged commit dc8ad62 into apache:master Feb 18, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants