Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test - testMultipleWrites #2926

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

GrantPSpencer
Copy link
Contributor

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Current test logic has strict assertion that GC should occur within 2*TTL of making the write calls. I believe the flakiness is due to this assertion being too strict and causes the test to fail when the CI's ZK server is overloaded and responses are slowed. The gc occurs on a separate thread so it may be delayed compared to the main test thread.

This change increases the test timeout to 60s as the test should be isolated from the performance of the ZK server.
This change also removes a redundant assertion

Tests

  • The following tests are written for this issue:

testMultipleWrites

Ran this change vs master on my personal fork, test frequently occurred on master but not on this branch

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@GrantPSpencer
Copy link
Contributor Author

Pull request approved by: @junkaixue
Commit message: Fix flaky test - testMultipleWrites

@junkaixue junkaixue merged commit 04a2400 into apache:master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants