Fix flaky test - testMultipleWrites #2926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
[Failed CI Test] testMultipleWrites(org.apache.helix.manager.zk.TestZkBucketDataAccessor) #2925
Description
Current test logic has strict assertion that GC should occur within 2*TTL of making the write calls. I believe the flakiness is due to this assertion being too strict and causes the test to fail when the CI's ZK server is overloaded and responses are slowed. The gc occurs on a separate thread so it may be delayed compared to the main test thread.
This change increases the test timeout to 60s as the test should be isolated from the performance of the ZK server.
This change also removes a redundant assertion
Tests
testMultipleWrites
Ran this change vs master on my personal fork, test frequently occurred on master but not on this branch
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)