-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support aggregated endpoint for customized stoppable check #2919
Support aggregated endpoint for customized stoppable check #2919
Conversation
could you please also update naming in pr? |
helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/RESTConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/RESTConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/RESTConfig.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java
Outdated
Show resolved
Hide resolved
Also could you please update the description with new naming? Thx 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have major concerns. But take a look of failure tests.
This PR is approved by @zpinto and @junkaixue. TFTR. It's ready to be merged. The commit message: "Support aggregated endpoint for customized stoppable check" |
Issues
Support aggregated customized stoppable check #2918
Description
instances
,toBeStoppedInstances
, and theclusterID
to the health check endpoint and expect the user to return the response regarding whether those instances are stoppable and the reason of being not stoppable.Tests
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)