Update bump-up.sh to remove deprecated helix-admin-webapp and helix-front #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ront Update bump-up.sh to remove deprecated helix-admin-webapp and helix-front
junkaixue
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As helix-admin-webapp and helix-front are deprecated,
<parent>'s version in pom.xml is not consistent with other modules.For example:
helix-admin-webapp/pom.xml: 1.3.2-SNAPSHOT linkpom.xmland other modules: 1.4.1-SNAPSHOT linkAs a result, the current version obtained by
bump-up.shfrompom.xml(get_version_from_pom) does not match what's inhelix-admin-webapp, so the find and replace fails:This PR removes helix-admin-webapp and helix-front from bump-up.sh so that it doesn't fail while attempting to "find and replace" version numbers from these deprecated modules (until they are permanently removed).