LockClient Minor Changes #2723
Merged
LockClient Minor Changes #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2024 13:41
xyuanlu
reviewed
Jan 3, 2024
| @@ -171,23 +169,23 @@ public void setClientData(String clientData) { | |||
| * Get the value for GRANTED_AT attribute of the lock | |||
| * @param grantTime Long representing the time at which the lock was granted | |||
| */ | |||
| public void setGrantedAt(Long grantTime) { | |||
| private void setGrantedAt(Long grantTime) { | |||
There was a problem hiding this comment.
Helper function when creating LockInfo's
xyuanlu
approved these changes
Jan 4, 2024
|
PR approved by @xyuanlu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2337
Description
Modifying constructor to not include not essential parameters. Private-ing helper methods to avoid confusion.
Tests
lockinfotest, lockclienttest
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)